# HG changeset patch # User Sergey Kandaurov # Date 1441367115 -10800 # Node ID 42de9efd11ee2264d4cc29965c5a54f8710f5ccd # Parent 2d10f958741d8e59391ebae98f05629cc5b37072 Tests: added HTTP/2 test for request header with newline. diff --git a/h2.t b/h2.t --- a/h2.t +++ b/h2.t @@ -32,7 +32,7 @@ plan(skip_all => 'IO::Socket::SSL too ol my $t = Test::Nginx->new()->has(qw/http http_ssl http_v2 proxy cache/) ->has(qw/limit_conn rewrite realip shmem/) - ->has_daemon('openssl')->plan(162); + ->has_daemon('openssl')->plan(163); $t->write_file_expand('nginx.conf', <<'EOF'); @@ -1420,6 +1420,20 @@ is($frame->{headers}->{':status'}, 200, # some invalid cases below +# ensure that request header field value with newline doesn't get split + +$sess = new_session(); +$sid = new_stream($sess, { headers => [ + { name => ':method', value => 'GET', mode => 0 }, + { name => ':scheme', value => 'http', mode => 0 }, + { name => ':path', value => '/proxy2/', mode => 1 }, + { name => ':authority', value => 'localhost', mode => 1 }, + { name => 'x-foo', value => "x-bar\r\nreferer:see-this", mode => 2 }]}); +$frames = h2_read($sess, all => [{ sid => $sid, fin => 1 }]); + +($frame) = grep { $_->{type} eq "HEADERS" } @$frames; +isnt($frame->{headers}->{'x-referer'}, 'see-this', 'newline in request header'); + # GOAWAY on SYN_STREAM with even StreamID TODO: {