# HG changeset patch # User Andrey Zelenkov # Date 1481026767 -10800 # Node ID 83b7b3f8b6c5f83a970c6cbd2a25886760bfaf30 # Parent 534d209f6ae45315dafef5f71b1e482de3b7749f Tests: added HTTP/2 tests with auth_request (ticket #1143). Previously, a request body bigger than "client_body_buffer_size" might result in sending corrupted body or cause a segfault. diff --git a/h2_auth_request.t b/h2_auth_request.t new file mode 100644 --- /dev/null +++ b/h2_auth_request.t @@ -0,0 +1,92 @@ +#!/usr/bin/perl + +# (C) Andrey Zelenkov +# (C) Nginx, Inc. + +# Tests for HTTP/2 protocol with auth_request. + +############################################################################### + +use warnings; +use strict; + +use Test::More; + +BEGIN { use FindBin; chdir($FindBin::Bin); } + +use lib 'lib'; +use Test::Nginx; +use Test::Nginx::HTTP2; + +############################################################################### + +select STDERR; $| = 1; +select STDOUT; $| = 1; + +my $t = Test::Nginx->new()->has(qw/http http_v2 rewrite proxy auth_request/) + ->plan(2); + +$t->write_file_expand('nginx.conf', <<'EOF'); + +%%TEST_GLOBALS%% + +daemon off; + +events { +} + +http { + %%TEST_GLOBALS_HTTP%% + + server { + listen 127.0.0.1:8080 http2; + listen 127.0.0.1:8081; + server_name localhost; + + location / { + return 200; + } + location /auth { + add_header X-Body-File $request_body_file; + client_body_buffer_size 512; + auth_request /auth_request; + proxy_pass http://127.0.0.1:8081/auth_proxy; + } + location /auth_request { + proxy_pass http://127.0.0.1:8081/; + proxy_pass_request_body off; + proxy_set_header Content-Length ""; + } + location /auth_proxy { + add_header X-Body $request_body; + proxy_pass http://127.0.0.1:8081/; + } + } +} + +EOF + +$t->run(); + +############################################################################### + +my ($s, $sid, $frames, $frame); + +TODO: { +todo_skip 'use-after-free', 2 unless $ENV{TEST_NGINX_UNSAFE} + or $t->has_version('1.11.7'); + +# second stream is used to induce body corruption issue + +$s = Test::Nginx::HTTP2->new(); +$sid = $s->new_stream({ path => '/auth', method => 'POST', body => 'A' x 600 }); +$s->new_stream({ path => '/auth', method => 'POST', body => 'B' x 600 }); +$frames = $s->read(all => [{ sid => $sid, fin => 1 }]); + +($frame) = grep { $_->{type} eq "HEADERS" } @$frames; +is($frame->{headers}->{'x-body'}, 'A' x 600, 'auth request body'); +isnt($frame->{headers}->{'x-body-file'}, undef, 'auth request body file'); + +} + +###############################################################################