# HG changeset patch # User Sergey Kandaurov # Date 1531117043 -10800 # Node ID ca6fe31f74c47ebc290b8289ca338f229071b08e # Parent afe5416490545c0a8c1fccbc3f0c87808442ead8 Tests: TODO grpc request body "first body bytes" test on FreeBSD. The test catches improper tcp_nopush usage, fixed in 8eab05b83dde. diff --git a/grpc_request_buffering.t b/grpc_request_buffering.t --- a/grpc_request_buffering.t +++ b/grpc_request_buffering.t @@ -88,14 +88,23 @@ is($frame->{flags}, 1, 'request - DATA f ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is($frame->{headers}{'x-body'}, 'Hello', 'request body in memory'); -# expect body cleanup is disabled with preserve_output (ticket #1565). -# after request body first bytes were proxied on behalf of initial window size, -# send response header from upstream, this leads to body cleanup code path +# tcp_nopush usage on peer connections +# reopen window for request body after initial window was exhausted + +TODO: { +local $TODO = 'not yet' if $t->read_file('nginx.conf') =~ /sendfile on/ + and !$t->has_version('1.15.1') and $^O eq 'freebsd'; $frames = $f->{http_start}('/proxy'); is(eval(join '+', map { $_->{length} } grep { $_->{type} eq "DATA" } @$frames), 65535, 'preserve_output - first body bytes'); +} + +# expect body cleanup is disabled with preserve_output (ticket #1565). +# after request body first bytes were proxied on behalf of initial window size, +# send response header from upstream, this leads to body cleanup code path + TODO: { local $TODO = 'not yet' unless $t->has_version('1.15.1');