# HG changeset patch # User Maxim Dounin # Date 1374762956 -14400 # Node ID e9de4da234c01b4d7b96ac640799f23aa6ac1751 # Parent 68b94b83412b566d7e5d2cc2f4e0e86f261ddeb7 Tests: add version checks to TODOs for committed patches. diff --git a/proxy_unfinished.t b/proxy_unfinished.t --- a/proxy_unfinished.t +++ b/proxy_unfinished.t @@ -99,7 +99,7 @@ http_get('/cache/length'); like(http_get('/cache/length'), qr/MISS/, 'unfinished not cached'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); # chunked encoding has enough information to don't cache a response, # much like with Content-Length available @@ -110,7 +110,7 @@ like(http_get('/cache/chunked'), qr/MISS } TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); # make sure there is no final chunk in unfinished responses @@ -129,7 +129,7 @@ like(http_get_11('/chunked/ok'), qr/fini 'chunked final chunk'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); # the same with proxy_buffering set to off @@ -153,7 +153,7 @@ like(http_get('/un/big', sleep => 0.1), like(http_get('/un/big/ok', sleep => 0.1), qr/finished/s, 'big finished un'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); # if disk buffering fails for some reason, there should be # no final chunk diff --git a/scgi_cache.t b/scgi_cache.t --- a/scgi_cache.t +++ b/scgi_cache.t @@ -72,7 +72,7 @@ like(http_get('/nolen'), qr/HIT/, 'no le like(http_get('/len/empty'), qr/MISS/, 'empty length'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/len/empty'), qr/HIT/, 'empty length cached'); } diff --git a/sub_filter.t b/sub_filter.t --- a/sub_filter.t +++ b/sub_filter.t @@ -87,7 +87,7 @@ like(http_get('/once?b=foofoo'), qr/barf like(http_get('/many?b=foofoo'), qr/barbar/, 'many'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/many?b=fo'), qr/fo/, 'incomplete'); like(http_get('/many?b=foofo'), qr/barfo/, 'incomplete long'); @@ -98,7 +98,7 @@ like(http_get('/complex?b=abac'), qr/_re like(http_get('/complex?b=abaabac'), qr/aba_replaced/, 'complex 1st char'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/complex?b=ababac'), qr/replaced/, 'complex 2nd char'); @@ -107,7 +107,7 @@ like(http_get('/complex?b=ababac'), qr/r like(http_get('/complex2?b=ababX'), qr/_replaced/, 'complex2'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/complex2?b=abababX'), qr/ab_replaced/, 'complex2 long'); @@ -116,7 +116,7 @@ like(http_get('/complex2?b=abababX'), qr like(http_get('/complex3?b=aab'), qr/_replaced/, 'complex3 aab in aab'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/complex3?b=aaab'), qr/a_replaced/, 'complex3 aab in aaab'); diff --git a/sub_filter_perl.t b/sub_filter_perl.t --- a/sub_filter_perl.t +++ b/sub_filter_perl.t @@ -95,7 +95,7 @@ like(http_get('/multi?a=a&b=ab'), qr/^_r like(http_get('/multi?a=a&b=aaab'), qr/^aa_replaced$/m, 'aab in a + aaab'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/multi?a=a&b=aab'), qr/^a_replaced$/m, 'aab in a + aab'); like(http_get('/multi?a=a&b=aaaab'), qr/^aaa_replaced$/m, 'aab in a + aaaab'); @@ -103,7 +103,7 @@ like(http_get('/multi?a=a&b=aaaab'), qr/ } TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/multi?a=aa&b=ab'), qr/^a_replaced$/m, 'aab in aa + ab'); like(http_get('/multi?a=aa&b=aab'), qr/^aa_replaced$/m, 'aab in aa + aab'); @@ -116,7 +116,7 @@ like(http_get('/multi?a=aa&b=aaaab'), qr # full backtracking TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/multi?a=aa&b=xaaab'), qr/^aaxa_replaced$/m, 'aab in aa + xaaab'); like(http_get('/multi?a=aa&b=axaaab'), qr/^aaaxa_replaced$/m, @@ -131,7 +131,7 @@ like(http_get('/multi?a=aa&b=aaxaaab'), like(http_get('/short?a=a&b=b'), qr/^_replaced$/m, 'ab in a + b'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/short?a=a&b=ab'), qr/^a_replaced$/m, 'ab in a + ab'); @@ -144,7 +144,7 @@ like(http_get('/short?a=a&b=aaaab'), qr/ like(http_get('/short?a=aa&b=b'), qr/^a_replaced$/m, 'ab in aa + b'); TODO: { -local $TODO = 'not yet'; +local $TODO = 'not yet' unless $t->has_version('1.5.3'); like(http_get('/short?a=aa&b=ab'), qr/^aa_replaced$/m, 'ab in aa + ab');