comparison src/http/v3/ngx_http_v3.h @ 9161:4939fd04737f

HTTP/3: postponed session creation to init() callback. Now the session object is assigned to c->data while ngx_http_connection_t object is referenced by its http_connection field, similar to ngx_http_v2_connection_t and ngx_http_request_t. The change allows to eliminate v3_session field from ngx_http_connection_t. The field was under NGX_HTTP_V3 macro, which was a source of binary compatibility problems when nginx/module is build with/without HTTP/3 support. Postponing is essential since c->data should retain the reference to ngx_http_connection_t object throughout QUIC handshake, because SSL callbacks ngx_http_ssl_servername() and ngx_http_ssl_alpn_select() rely on this.
author Roman Arutyunyan <arut@nginx.com>
date Thu, 14 Sep 2023 14:13:43 +0400
parents f742b1b46901
children
comparison
equal deleted inserted replaced
9160:dd5fd5719027 9161:4939fd04737f
76 #define NGX_HTTP_V3_ERR_DECOMPRESSION_FAILED 0x200 76 #define NGX_HTTP_V3_ERR_DECOMPRESSION_FAILED 0x200
77 #define NGX_HTTP_V3_ERR_ENCODER_STREAM_ERROR 0x201 77 #define NGX_HTTP_V3_ERR_ENCODER_STREAM_ERROR 0x201
78 #define NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR 0x202 78 #define NGX_HTTP_V3_ERR_DECODER_STREAM_ERROR 0x202
79 79
80 80
81 #define ngx_http_quic_get_connection(c) \ 81 #define ngx_http_v3_get_session(c) \
82 ((ngx_http_connection_t *) ((c)->quic ? (c)->quic->parent->data \ 82 ((ngx_http_v3_session_t *) ((c)->quic ? (c)->quic->parent->data \
83 : (c)->data)) 83 : (c)->data))
84 84
85 #define ngx_http_v3_get_session(c) ngx_http_quic_get_connection(c)->v3_session 85 #define ngx_http_quic_get_connection(c) \
86 (ngx_http_v3_get_session(c)->http_connection)
86 87
87 #define ngx_http_v3_get_module_loc_conf(c, module) \ 88 #define ngx_http_v3_get_module_loc_conf(c, module) \
88 ngx_http_get_module_loc_conf(ngx_http_quic_get_connection(c)->conf_ctx, \ 89 ngx_http_get_module_loc_conf(ngx_http_quic_get_connection(c)->conf_ctx, \
89 module) 90 module)
90 91
118 ngx_array_t *cookies; 119 ngx_array_t *cookies;
119 }; 120 };
120 121
121 122
122 struct ngx_http_v3_session_s { 123 struct ngx_http_v3_session_s {
124 ngx_http_connection_t *http_connection;
125
123 ngx_http_v3_dynamic_table_t table; 126 ngx_http_v3_dynamic_table_t table;
124 127
125 ngx_event_t keepalive; 128 ngx_event_t keepalive;
126 ngx_uint_t nrequests; 129 ngx_uint_t nrequests;
127 130