comparison src/event/quic/ngx_event_quic_migration.c @ 8917:bb1d1d9d76e2 quic

QUIC: removed excessive check. The c->udp->dgram may be NULL only if the quic connection was just created: the ngx_event_udp_recvmsg() passes information about datagrams to existing connections by providing information in c->udp. If case of a new connection, c->udp is allocated by the QUIC code during creation of quic connection (it uses c->sockaddr to initialize qsock->path). Thus the check for qsock->path is excessive and can be read wrong, assuming that other options possible, leading to warnings from clang static analyzer.
author Vladimir Homutov <vl@nginx.com>
date Wed, 01 Dec 2021 18:33:29 +0300
parents 40445fc7c403
children 501f28679d56
comparison
equal deleted inserted replaced
8916:ff473a6f656c 8917:bb1d1d9d76e2
287 ngx_quic_client_id_t *cid; 287 ngx_quic_client_id_t *cid;
288 ngx_quic_connection_t *qc; 288 ngx_quic_connection_t *qc;
289 289
290 qsock = ngx_quic_get_socket(c); 290 qsock = ngx_quic_get_socket(c);
291 291
292 if (c->udp->dgram == NULL && qsock->path) { 292 if (c->udp->dgram == NULL) {
293 /* 1st ever packet in connection, path already exists */ 293 /* 1st ever packet in connection, path already exists */
294 path = qsock->path; 294 path = qsock->path;
295 goto update; 295 goto update;
296 } 296 }
297 297