Mercurial > hg > nginx
comparison src/mail/ngx_mail_imap_handler.c @ 9234:c690a902bfec
Mail: handling of read buffer filled with commands.
If the whole read buffer was filled with commands during authentication,
exactly matching the buffer boundary, this did not cause the "client sent
too long command" error, but might result in read events being disabled
for the connection, notably with level-triggered event methods, leading
to a connection hang.
Fix is to ensure that s->blocked is set in case of c->read->ready, so
command reading is resumed after sending responses to previous commands.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Sat, 30 Mar 2024 05:05:05 +0300 |
parents | b38728495e1a |
children | d7fd0acdea64 |
comparison
equal
deleted
inserted
replaced
9233:9ca12c957304 | 9234:c690a902bfec |
---|---|
224 } else if (rc == NGX_IMAP_NEXT) { | 224 } else if (rc == NGX_IMAP_NEXT) { |
225 tag = 0; | 225 tag = 0; |
226 ngx_str_set(&s->out, imap_next); | 226 ngx_str_set(&s->out, imap_next); |
227 } | 227 } |
228 | 228 |
229 if (s->buffer->pos < s->buffer->last) { | 229 if (s->buffer->pos < s->buffer->last || c->read->ready) { |
230 s->blocked = 1; | 230 s->blocked = 1; |
231 } | 231 } |
232 | 232 |
233 switch (rc) { | 233 switch (rc) { |
234 | 234 |