# HG changeset patch # User Vladimir Homutov # Date 1587633900 -10800 # Node ID 2a6e91a1691decc8f31f544ec5bbed5f7c86ccd2 # Parent 05b8dd5d9f7e75a0d1ac5b25cc3c4d82a3fba5bb TODOs cleanup in transport. We always generate stream frames that have length. The 'len' member is used during parsing incoming frames and can be safely ignored when generating output. diff --git a/src/event/ngx_event_quic_transport.c b/src/event/ngx_event_quic_transport.c --- a/src/event/ngx_event_quic_transport.c +++ b/src/event/ngx_event_quic_transport.c @@ -1267,15 +1267,6 @@ ngx_quic_create_stream(u_char *p, ngx_qu size_t len; u_char *start; - if (!sf->len) { -#if 0 - ngx_log_error(NGX_LOG_INFO, log, 0, - "attempt to generate a stream frame without length"); -#endif - // XXX: handle error in caller - return NGX_ERROR; - } - if (p == NULL) { len = ngx_quic_varint_len(sf->type); @@ -1345,7 +1336,7 @@ ngx_quic_parse_transport_param(u_char *p case NGX_QUIC_TP_ORIGINAL_CONNECTION_ID: case NGX_QUIC_TP_STATELESS_RESET_TOKEN: case NGX_QUIC_TP_PREFERRED_ADDRESS: - // TODO + /* TODO: implement */ return NGX_DECLINED; }