# HG changeset patch
# User Vladimir Homutov <vl@nginx.com>
# Date 1638372809 -10800
# Node ID bb1d1d9d76e2560e0333a991349e32426c985f09
# Parent  ff473a6f656c016cf9d82a0acd2a3f7932515f4e
QUIC: removed excessive check.

The c->udp->dgram may be NULL only if the quic connection was just
created: the ngx_event_udp_recvmsg() passes information about datagrams
to existing connections by providing information in c->udp.

If case of a new connection, c->udp is allocated by the QUIC code during
creation of quic connection (it uses c->sockaddr to initialize qsock->path).

Thus the check for qsock->path is excessive and can be read wrong, assuming
that other options possible, leading to warnings from clang static analyzer.

diff --git a/src/event/quic/ngx_event_quic_migration.c b/src/event/quic/ngx_event_quic_migration.c
--- a/src/event/quic/ngx_event_quic_migration.c
+++ b/src/event/quic/ngx_event_quic_migration.c
@@ -289,7 +289,7 @@ ngx_quic_update_paths(ngx_connection_t *
 
     qsock = ngx_quic_get_socket(c);
 
-    if (c->udp->dgram == NULL && qsock->path) {
+    if (c->udp->dgram == NULL) {
         /* 1st ever packet in connection, path already exists */
         path = qsock->path;
         goto update;