Mercurial > hg > nginx

changeset 9056:be39ffdf9208 quic

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
QUIC: removed cancelable flag from QUIC and HTTP/3 events. All these events are created in context of a client connection and are deleted when the connection is closed. Setting ev->cancelable could trigger premature connection closure and a socket leak alert.
author Roman Arutyunyan <arut@nginx.com>
date Wed, 30 Nov 2022 14:09:08 +0400
parents 1192923be0aa
children 7b83da3bdf9f
files src/event/quic/ngx_event_quic.c src/http/v3/ngx_http_v3.c
diffstat 2 files changed, 0 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/src/event/quic/ngx_event_quic.c
+++ b/src/event/quic/ngx_event_quic.c
@@ -275,22 +275,18 @@ ngx_quic_new_connection(ngx_connection_t
     qc->pto.log = c->log;
     qc->pto.data = c;
     qc->pto.handler = ngx_quic_pto_handler;
-    qc->pto.cancelable = 1;
 
     qc->push.log = c->log;
     qc->push.data = c;
     qc->push.handler = ngx_quic_push_handler;
-    qc->push.cancelable = 1;
 
     qc->close.log = c->log;
     qc->close.data = c;
     qc->close.handler = ngx_quic_close_handler;
-    qc->close.cancelable = 1;
 
     qc->path_validation.log = c->log;
     qc->path_validation.data = c;
     qc->path_validation.handler = ngx_quic_path_validation_handler;
-    qc->path_validation.cancelable = 1;
 
     qc->conf = conf;
 
--- a/src/http/v3/ngx_http_v3.c
+++ b/src/http/v3/ngx_http_v3.c
@@ -55,7 +55,6 @@ ngx_http_v3_init_session(ngx_connection_
     h3c->keepalive.log = pc->log;
     h3c->keepalive.data = pc;
     h3c->keepalive.handler = ngx_http_v3_keepalive_handler;
-    h3c->keepalive.cancelable = 1;
 
     h3c->table.send_insert_count.log = pc->log;
     h3c->table.send_insert_count.data = pc;