# HG changeset patch # User Maxim Dounin # Date 1314755033 -14400 # Node ID c5b498c5aa3c4604720c51f14156c7b7db234544 # Parent c7c4b2d68fdff3ebb59a4c5b047e0c606b34ee24 Keepalive: update comments, style. diff --git a/ngx_http_upstream_keepalive_module.c b/ngx_http_upstream_keepalive_module.c --- a/ngx_http_upstream_keepalive_module.c +++ b/ngx_http_upstream_keepalive_module.c @@ -318,19 +318,8 @@ ngx_http_upstream_free_keepalive_peer(ng * make sure that u->length is valid (we use u->header_sent flag to test * this). Memcached is the only supported protocol for now. * - * Some notes on other possibilities (incomplete): - * - * fastcgi: u->pipe->upstream_done should be sufficient - * - * proxy buffered: u->pipe->upstream_done, 304 replies, replies to head - * requests (see RFC 2616, 4.4 Message Length) - * - * proxy unbuffered: 200 as for memcached (with u->length == 0 and - * header_sent), 304, replies to head requests - * - * subrequest_in_memory: won't work as of now - * - * TODO: move this logic to protocol modules (NGX_PEER_KEEPALIVE?) + * With experimental patches we are able to cache other connections as + * well. Connection status is signalled via u->keepalive flag. */ u = kp->upstream; @@ -534,9 +523,7 @@ ngx_http_upstream_keepalive(ngx_conf_t * for (i = 2; i < cf->args->nelts; i++) { if (ngx_strcmp(value[i].data, "single") == 0) { - kcf->single = 1; - continue; }