convert: fix mercurial_sink.putcommit Changeset 4ebc8693ce72 added some code to putcommit to avoid creating a revision that touches no files, but this can break regular conversions from some repositories: - conceptually, since we're converting a repo, we should try to make the new hg repo as similar as possible to the original repo - we should create a new changeset, even if the original revision didn't touch any files (maybe the commit message had some important bit); - even if a "regular" revision that doesn't touch any file may seem weird (and maybe even broken), it's completely legitimate for a merge revision to not touch any file, and, if we just skip it, the converted repo will end up with wrong history and possibly an extra head. As an example, say the crew and main hg repos are sync'ed. Somebody sends an important patch to the mailing list. Matt quickly applies and pushes it. But at the same time somebody also applies it to crew and pushes it. Suppose the commit message ended up being a bit different (say, there was a typo and somebody didn't fix it) or that the date ended up being different (because of different patch-applying scripts): the changeset hashes will be different, but the manifests will be the same. Since both changesets were pushed to public repos, it's hard to recall them. If both are merged, the manifest from the resulting merge revision will have the exact same contents as its parents - i.e. the merge revision really doesn't touch any file at all. To keep the file filtering stuff "working", the generic code was changed to skip empty revisions if we're filtering the repo, fixing a bug in the process (we want parents[0] instead of tip).

     1

#!/bin/sh

     2

#

     3

# Corrupt an hg repo with a pull started during an aborted commit

     4

#

     5

     6

# Create two repos, so that one of them can pull from the other one.

     7

hg init source

     8

cd source

     9

touch foo

    10

hg add foo

    11

hg ci -m 'add foo'

    12

hg clone . ../corrupted

    13

echo >> foo

    14

hg ci -m 'change foo'

    15

    16

# Add a hook to wait 5 seconds and then abort the commit

    17

cd ../corrupted

    18

echo '[hooks]' >> .hg/hgrc

    19

echo 'pretxncommit = sleep 5; exit 1' >> .hg/hgrc

    20

    21

# start a commit...

    22

touch bar

    23

hg add bar

    24

hg ci -m 'add bar' &

    25

    26

# ... and start a pull while the commit is still running

    27

sleep 1

    28

hg pull ../source 2>/dev/null

    29

    30

# see what happened

    31

wait

    32

hg verify