[PATCH] Harden os.system -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [PATCH] Harden os.system From: Bryan O'Sullivan <bos@serpentine.com> Add util.system function. This is similar to os.system, but will either succeed (if the process finishes with a zero exit code) or raise a util.CommandError (if the process exits uncleanly or is killed by a signal). Add util.explain_exit function. This tends to be ubiquitous in code that calls other processes, and must describe what has gone wrong. Change some uses of os.system over to util.system. manifest hash: e3bf4adcac5b915432ec0af00efdbcef86bea4b1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCwSipywK+sNU5EO8RAr0RAJkBDt8XQ7mYQAWNHNgTOVt1eyWU1QCfe1oO 2OwxyWqpbRNACVJHHfZ3/Xw= =OaRX -----END PGP SIGNATURE-----

     1

#!/bin/sh -ex

     2

     3

umask 027

     4

mkdir test1

     5

cd test1

     6

     7

hg init

     8

touch a b

     9

hg add a b

    10

hg ci -t "added a b" -u test -d "0 0"

    11

    12

cd ..

    13

mkdir test2

    14

cd test2

    15

    16

hg init

    17

hg pull ../test1

    18

hg co

    19

chmod +x a

    20

hg ci -t "chmod +x a" -u test -d "0 0"

    21

    22

cd ../test1

    23

echo 123 >>a

    24

hg ci -t "a updated" -u test -d "0 0"

    25

    26

hg pull ../test2

    27

hg heads

    28

hg history

    29

    30

hg -dv co -m

    31

    32

ls -l ../test[12]/a > foo

    33

cut -b 0-10 < foo

    34