[PATCH] Harden os.system -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [PATCH] Harden os.system From: Bryan O'Sullivan <bos@serpentine.com> Add util.system function. This is similar to os.system, but will either succeed (if the process finishes with a zero exit code) or raise a util.CommandError (if the process exits uncleanly or is killed by a signal). Add util.explain_exit function. This tends to be ubiquitous in code that calls other processes, and must describe what has gone wrong. Change some uses of os.system over to util.system. manifest hash: e3bf4adcac5b915432ec0af00efdbcef86bea4b1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCwSipywK+sNU5EO8RAr0RAJkBDt8XQ7mYQAWNHNgTOVt1eyWU1QCfe1oO 2OwxyWqpbRNACVJHHfZ3/Xw= =OaRX -----END PGP SIGNATURE-----

     1

#!/bin/sh -x

     2

     3

mkdir t

     4

cd t

     5

hg init

     6

echo This is file a1 > a

     7

echo This is file b1 > b

     8

hg add a b

     9

hg commit -t "commit #0" -d "0 0" -u user

    10

echo This is file b22 > b

    11

hg commit -t"comment #1" -d "0 0" -u user

    12

hg update 0

    13

rm b

    14

hg commit -A -t"comment #2" -d "0 0" -u user

    15

# in theory, we shouldn't need the "yes k" below, but it prevents

    16

# this test from hanging when "hg update" erroneously prompts the

    17

# user for "keep or delete"

    18

yes k | hg update 1

    19

# we exit with 0 to avoid the unavoidable SIGPIPE from above causing

    20

# us to fail this test

    21

exit 0