fix race in localrepo.addchangegroup. localrepo.addchangegroup writes to changelog, then manifest, then normal files. this breaks access ordering. if reader reads changelog while manifest is being written, can find pointers into places in manifest that are not yet written. same can happen for manifest and normal files. fix is to make almost no change to localrepo.addchangegroup. it must to write changelog and manifest data early because it has to read them while writing other files. instead, write changelog and manifest data to temp file that reader cannot see, then append temp data to manifest after all normal files written, finally append temp data to changelog. temp file code is in new appendfile module. can be used in other places with small changes. much smaller race still left. we write all new data in one write call, but reader can maybe see partial update because python or os or filesystem cannot always make write really atomic. file locking no help: slow, not portable, not reliable over nfs. only real safe other plan is write to temp file every time and rename, but performance bad when manifest or changelog is big.

     1

#!/bin/sh

     2

#

     3

# This is an example of using HGEDITOR to create of diff to review the

     4

# changes while commiting.

     5

     6

# If you want to pass your favourite editor some other parameters

     7

# only for Mercurial, modify this:

     8

case "${EDITOR}" in

     9

    "")

    10

        EDITOR="vi"

    11

        ;;

    12

    emacs)

    13

        EDITOR="$EDITOR -nw"

    14

        ;;

    15

    gvim|vim)

    16

        EDITOR="$EDITOR -f -o"

    17

        ;;

    18

esac

    19

    20

    21

HGTMP=""

    22

cleanup_exit() {

    23

    rm -rf "$HGTMP"

    24

}

    25

    26

# Remove temporary files even if we get interrupted

    27

trap "cleanup_exit" 0 # normal exit

    28

trap "exit 255" 1 2 3 6 15 # HUP INT QUIT ABRT TERM

    29

    30

HGTMP="${TMPDIR-/tmp}/hgeditor.$RANDOM.$RANDOM.$RANDOM.$$"

    31

(umask 077 && mkdir "$HGTMP") || {

    32

    echo "Could not create temporary directory! Exiting." 1>&2

    33

    exit 1

    34

}

    35

    36

(

    37

    grep '^HG: changed' "$1" | cut -b 13- | while read changed; do

    38

        hg diff "$changed" >> "$HGTMP/diff"

    39

    done

    40

)

    41

    42

cat "$1" > "$HGTMP/msg"

    43

    44

CHECKSUM=`md5sum "$HGTMP/msg"`

    45

if [ -s "$HGTMP/diff" ]; then

    46

    $EDITOR "$HGTMP/msg" "$HGTMP/diff" || exit $?

    47

else

    48

    $EDITOR "$HGTMP/msg" || exit $?

    49

fi

    50

echo "$CHECKSUM" | md5sum -c >/dev/null 2>&1 && exit 13

    51

    52

mv "$HGTMP/msg" "$1"

    53

    54

exit $?