fix race in localrepo.addchangegroup. localrepo.addchangegroup writes to changelog, then manifest, then normal files. this breaks access ordering. if reader reads changelog while manifest is being written, can find pointers into places in manifest that are not yet written. same can happen for manifest and normal files. fix is to make almost no change to localrepo.addchangegroup. it must to write changelog and manifest data early because it has to read them while writing other files. instead, write changelog and manifest data to temp file that reader cannot see, then append temp data to manifest after all normal files written, finally append temp data to changelog. temp file code is in new appendfile module. can be used in other places with small changes. much smaller race still left. we write all new data in one write call, but reader can maybe see partial update because python or os or filesystem cannot always make write really atomic. file locking no help: slow, not portable, not reliable over nfs. only real safe other plan is write to temp file every time and rename, but performance bad when manifest or changelog is big.

     1

import getopt

     2

     3

def fancyopts(args, options, state):

     4

    long = []

     5

    short = ''

     6

    map = {}

     7

    dt = {}

     8

     9

    for s, l, d, c in options:

    10

        pl = l.replace('-', '_')

    11

        map['-'+s] = map['--'+l] = pl

    12

        state[pl] = d

    13

        dt[pl] = type(d)

    14

        if not d is None and not callable(d):

    15

            if s: s += ':'

    16

            if l: l += '='

    17

        if s: short = short + s

    18

        if l: long.append(l)

    19

    20

    opts, args = getopt.getopt(args, short, long)

    21

    22

    for opt, arg in opts:

    23

        if dt[map[opt]] is type(fancyopts): state[map[opt]](state,map[opt],arg)

    24

        elif dt[map[opt]] is type(1): state[map[opt]] = int(arg)

    25

        elif dt[map[opt]] is type(''): state[map[opt]] = arg

    26

        elif dt[map[opt]] is type([]): state[map[opt]].append(arg)

    27

        elif dt[map[opt]] is type(None): state[map[opt]] = 1

    28

    29

    return args

    30