annotate templates/error-gitweb.tmpl @ 1998:65cc17ae9649

fix race in localrepo.addchangegroup. localrepo.addchangegroup writes to changelog, then manifest, then normal files. this breaks access ordering. if reader reads changelog while manifest is being written, can find pointers into places in manifest that are not yet written. same can happen for manifest and normal files. fix is to make almost no change to localrepo.addchangegroup. it must to write changelog and manifest data early because it has to read them while writing other files. instead, write changelog and manifest data to temp file that reader cannot see, then append temp data to manifest after all normal files written, finally append temp data to changelog. temp file code is in new appendfile module. can be used in other places with small changes. much smaller race still left. we write all new data in one write call, but reader can maybe see partial update because python or os or filesystem cannot always make write really atomic. file locking no help: slow, not portable, not reliable over nfs. only real safe other plan is write to temp file every time and rename, but performance bad when manifest or changelog is big.
author Vadim Gelfer <vadim.gelfer@gmail.com>
date Fri, 24 Mar 2006 09:08:12 -0800
parents 686bf56c17d0
children 783220e5d2d1
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1572
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
1 #header#
1776
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
2 <title>#repo|escape#: Error</title>
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
3 <link rel="alternate" type="application/rss+xml"
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
4 href="?cmd=changelog;style=rss" title="RSS feed for #repo|escape#">
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
5 </head>
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
6 <body>
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
7
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
8 <div class="page_header">
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
9 <a href="http://www.selenic.com/mercurial/" title="Mercurial"><div style="float:right;">Mercurial</div></a><a href="?cmd=summary;style=gitweb">#repo|escape#</a> / error
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
10 </div>
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
11
1572
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
12 <div class="page_nav">
1776
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
13 <a href="?cmd=summary;style=gitweb">summary</a> | <a href="?cmd=changelog;style=gitweb">changelog</a> | <a href="?cmd=tags;style=gitweb">tags</a> | <a href="?cmd=manifest;manifest=#manifest#;path=/;style=gitweb">manifest</a><br/>
1572
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
14 </div>
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
15
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
16 <div>
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
17 <br/>
1776
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents: 1572
diff changeset
18 <i>An error occured while processing your request</i><br/>
1572
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
19 <br/>
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
20 </div>
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
21
385b8872b8e3 [hgweb] Initial import of the "gitweb" style
Josef "Jeff" Sipek <jeffpc@optonline.net>
parents:
diff changeset
22 #footer#