Don't try to determine interactivity if ui() called with interactive=False. WSGI applications are not supposed to refer to sys.stdin. In ed6df6b1c29a, hgweb and hgwebdir were fixed to pass interactive=False to their ui()'s, but sys.stdin.isatty() was still called by the ui objects. This change makes sure only the ui.fixconfig() method will call ui.isatty() (by making the ui._readline() method, which is currently only called from ui.prompt(), private). ui.fixconfig() is changed to let config files override the initial interactivity setting, but not check isatty() if interactive=False was specified in the creation of the ui.

     1

% should fail

     2

abort: path contains illegal component: .hg/00changelog.i

     3

adding a/a

     4

% should fail

     5

abort: path 'b/b' traverses symbolic link 'b'

     6

% should succeed

     7

% should still fail - maybe

     8

abort: path 'b/b' traverses symbolic link 'b'