dirstate walking optimizations The repo walking code introduces a number of calls to dirstate.map.copy(), significantly slowing down the walk on large trees. When a list of files is passed to the walking code, we should only look at map entries relevant to the file list passed in. dirstate.filterfiles() is added to return a subset of the dirstate map. The subset includes in files passed in, and if one of the files requested is actually a directory, it includes any files inside that directory tree. This brings the time for hg diff Makefile down from 1.7s to .3s on a linux kernel repo. Also, the diff command was unconditionally calling makewalk, leading to an extra pass through repo.changes. This patch avoids the call to makewalk when commands.diff isn't given a list of patterns, cutting the time for hg diff (with no args) in half. Index: mine/mercurial/hg.py ===================================================================

     1

<table class="changelogEntry parity#parity#">

     2

 <tr>

     3

  <th class="age">#date|age# ago:</th>

     4

  <th class="firstline">#desc|firstline|escape#</th>

     5

 </tr>

     6

 <tr>

     7

  <th class="changesetRev">changeset #rev#:</th>

     8

  <td class="changesetNode"><a href="?cmd=changeset;node=#node#">#node|short#</a></td>

     9

 </tr>

    10

 #parent#

    11

 #changelogtag#

    12

 <tr>

    13

  <th class="author">author:</th>

    14

  <td class="author">#author|obfuscate#</td>

    15

 </tr>

    16

 <tr>

    17

  <th class="date">date:</th>

    18

  <td class="date">#date|date#</td>

    19

 </tr>

    20

 <tr>

    21

  <th class="files"><a href="?cmd=manifest;manifest=#manifest#;path=/">files</a>:</th>

    22

  <td class="files">#files#</td>

    23

 </tr>

    24

</table>