dirstate walking optimizations The repo walking code introduces a number of calls to dirstate.map.copy(), significantly slowing down the walk on large trees. When a list of files is passed to the walking code, we should only look at map entries relevant to the file list passed in. dirstate.filterfiles() is added to return a subset of the dirstate map. The subset includes in files passed in, and if one of the files requested is actually a directory, it includes any files inside that directory tree. This brings the time for hg diff Makefile down from 1.7s to .3s on a linux kernel repo. Also, the diff command was unconditionally calling makewalk, leading to an extra pass through repo.changes. This patch avoids the call to makewalk when commands.diff isn't given a list of patterns, cutting the time for hg diff (with no args) in half. Index: mine/mercurial/hg.py ===================================================================

     1

+ hg init

     2

+ hg add t1

     3

+ hg commit -m 1 -d 0 0

     4

+ hg clone a b

     5

+ hg add t2

     6

+ hg commit -m 2 -d 0 0

     7

+ hg add t3

     8

+ hg commit -m 3 -d 0 0

     9

+ hg push ../a

    10

pushing to ../a

    11

searching for changes

    12

abort: unsynced remote changes!

    13

(did you forget to sync? use push -f to force)

    14

+ hg pull ../a

    15

pulling from ../a

    16

searching for changes

    17

adding changesets

    18

adding manifests

    19

adding file changes

    20

added 1 changesets with 1 changes to 1 files

    21

(run 'hg update' to get a working copy)

    22

+ hg push ../a

    23

pushing to ../a

    24

searching for changes

    25

abort: push creates new remote branches!

    26

(did you forget to merge? use push -f to force)

    27

+ hg up -m

    28

+ hg commit -m 4 -d 0 0

    29

+ hg push ../a

    30

pushing to ../a

    31

searching for changes

    32

adding changesets

    33

adding manifests

    34

adding file changes

    35

added 2 changesets with 2 changes to 2 files