Teach walk code about absolute paths. The first consequence of this is that absolute and relative paths now all work in the same way. The second is that paths that lie outside the repository now cause an error to be reported, instead of something arbitrary and expensive being done. Internally, all of the serious work is in the util package. The new canonpath function takes an arbitrary path and either returns a canonical path or raises an error. Because it needs to know where the repository root is, it must be fed a repository or dirstate object, which has given commands.matchpats and friends a new parameter to pass along. The util.matcher function uses this to canonicalise globs and relative path names. Meanwhile, I've moved the Abort exception from commands to util, and killed off the redundant util.CommandError exception.

     1

#!/bin/sh

     2

     3

# No local source

     4

hg clone a b

     5

echo $?

     6

     7

# No remote source

     8

hg clone http://127.0.0.1:3121/a b

     9

echo $?

    10

rm -rf b # work around bug with http clone

    11

    12

# Inaccessible source

    13

mkdir a

    14

chmod 000 a

    15

hg clone a b

    16

echo $?

    17

    18

# Inaccessible destination

    19

mkdir b

    20

cd b

    21

hg init

    22

hg clone . ../a

    23

echo $?

    24

cd ..

    25

chmod 700 a

    26

rm -rf a b

    27

    28

# Source of wrong type

    29

mkfifo a

    30

hg clone a b

    31

echo $?

    32

rm a

    33

    34

# Default destination, same directory

    35

mkdir q

    36

cd q

    37

hg init

    38

cd ..

    39

hg clone q

    40

    41

true