Fix zombie files in merge # HG changeset patch # User maf46@burn.cl.cam.ac.uk # Node ID 57667c9b93a5a743e4629d15a0e6bd76699130c3 # Parent d2994b5298fb20f87dc1d4747635b280db3c0526 Fix zombie files in merge Keir Fraser observed the following: > I made a small test case that illustrates the bug in merging changesets > with 'hg remove's in them: > > 1. Create a repository A containing files foo & bar. > 2. Create clone called B. > 3. A removes file bar, and commits this removal. > 4. B edits file foo, and commits this edit. > > Now, if B: > # hg pull ../A; hg update -m; hg commit > Then bar remains deleted. > > If A: > # hg pull ../B; hg update -m; hg commit > Then bar is resurrected! > > It looks as though, when you merge across a branch, any deletions in > your own branch are forgotten. > ... > Fixing this is a must, as zombie files are a real pain. :-) Keir later patched our local copy of hg as shown below, which fixes the problem. I've also enclosed a test which captures the test Keir outlined... Files deleted on a branch should not automatically reappear in a merge Patch notes: 1. The first chunk does not change behaviour, but cleans up the code to more closely match check of 'force' in the second chunk. I think it makes the code clearer. 2. The second chunk fixes two bugs -- i. If we choose to keep a remotely-changed locally-deleted file, then we need to 'get' that file. If we choose to delete it then no action need be taken (it is already deleted in the working manifest). Without this fix, choosing to delete would get a Python traceback. ii. The test for whether the file was remotely-created is insufficient. It is only true if f is not in the common ancestor. Otherwise the file was deleted locally, and should remain deleted. (this is the most important fix!) Index: hg/tests/test-merge6 ===================================================================

     1

#!/bin/sh

     2

#

     3

# Build a Mercurial RPM in place.

     4

#

     5

# Bryan O'Sullivan <bos@serpentine.com>

     6

     7

root="`hg root 2>/dev/null`"

     8

specfile=contrib/mercurial.spec

     9

    10

if [ -z "$root" ]; then

    11

    echo 'You are not inside a Mercurial repository!' 1>&2

    12

    exit 1

    13

fi

    14

    15

rpmdir=/tmp/"`basename $root | sed 's/ /_/'`"-rpm

    16

    17

cd "$root"

    18

rm -rf $rpmdir

    19

mkdir -p $rpmdir/RPMS

    20

hg clone "$root" $rpmdir/BUILD

    21

    22

if [ ! -f $specfile ]; then

    23

    echo "Cannot find $specfile!" 1>&2

    24

    exit 1

    25

fi

    26

    27

tmpspec=/tmp/`basename "$specfile"`.$$

    28

# Use the most recent tag as the version.

    29

version=`hg tags | perl -e 'while(<STDIN>){if(/^(\d\S+)/){print$1;exit}}'`

    30

# Compute the release number as the difference in revision numbers

    31

# between the tip and the most recent tag.

    32

release=`hg tags | perl -e 'while(<STDIN>){/^(\S+)\s+(\d+)/;if($1eq"tip"){$t=$2}else{print$t-$2+1;exit}}'`

    33

tip=`hg -q tip`

    34

    35

# Beat up the spec file

    36

sed -e 's,^Source:.*,Source: /dev/null,' \

    37

    -e "s,^Version:.*,Version: $version," \

    38

    -e "s,^Release:.*,Release: $release," \

    39

    -e "s,^%prep.*,Changeset: $tip\n\0," \

    40

    -e 's,^%setup.*,,' \

    41

    $specfile > $tmpspec

    42

    43

rpmbuild --define "_topdir $rpmdir" -bb $tmpspec

    44

if [ $? = 0 ]; then

    45

    rm -rf $tmpspec $rpmdir/BUILD

    46

    mv $rpmdir/RPMS/*/* $rpmdir && rm -r $rpmdir/RPMS

    47

    echo

    48

    echo "Packages are in $rpmdir"

    49

fi