Fix zombie files in merge # HG changeset patch # User maf46@burn.cl.cam.ac.uk # Node ID 57667c9b93a5a743e4629d15a0e6bd76699130c3 # Parent d2994b5298fb20f87dc1d4747635b280db3c0526 Fix zombie files in merge Keir Fraser observed the following: > I made a small test case that illustrates the bug in merging changesets > with 'hg remove's in them: > > 1. Create a repository A containing files foo & bar. > 2. Create clone called B. > 3. A removes file bar, and commits this removal. > 4. B edits file foo, and commits this edit. > > Now, if B: > # hg pull ../A; hg update -m; hg commit > Then bar remains deleted. > > If A: > # hg pull ../B; hg update -m; hg commit > Then bar is resurrected! > > It looks as though, when you merge across a branch, any deletions in > your own branch are forgotten. > ... > Fixing this is a must, as zombie files are a real pain. :-) Keir later patched our local copy of hg as shown below, which fixes the problem. I've also enclosed a test which captures the test Keir outlined... Files deleted on a branch should not automatically reappear in a merge Patch notes: 1. The first chunk does not change behaviour, but cleans up the code to more closely match check of 'force' in the second chunk. I think it makes the code clearer. 2. The second chunk fixes two bugs -- i. If we choose to keep a remotely-changed locally-deleted file, then we need to 'get' that file. If we choose to delete it then no action need be taken (it is already deleted in the working manifest). Without this fix, choosing to delete would get a Python traceback. ii. The test for whether the file was remotely-created is insufficient. It is only true if f is not in the common ancestor. Otherwise the file was deleted locally, and should remain deleted. (this is the most important fix!) Index: hg/tests/test-merge6 ===================================================================

     1

# lock.py - simple locking scheme for mercurial

     2

#

     3

# Copyright 2005 Matt Mackall <mpm@selenic.com>

     4

#

     5

# This software may be used and distributed according to the terms

     6

# of the GNU General Public License, incorporated herein by reference.

     7

     8

import os, time

     9

import util

    10

    11

class LockHeld(Exception):

    12

    pass

    13

    14

class lock:

    15

    def __init__(self, file, wait = 1):

    16

        self.f = file

    17

        self.held = 0

    18

        self.wait = wait

    19

        self.lock()

    20

    21

    def __del__(self):

    22

        self.release()

    23

    24

    def lock(self):

    25

        while 1:

    26

            try:

    27

                self.trylock()

    28

                return 1

    29

            except LockHeld, inst:

    30

                if self.wait:

    31

                    time.sleep(1)

    32

                    continue

    33

                raise inst

    34

    35

    def trylock(self):

    36

        pid = os.getpid()

    37

        try:

    38

            util.makelock(str(pid), self.f)

    39

            self.held = 1

    40

        except:

    41

            raise LockHeld(util.readlock(self.f))

    42

    43

    def release(self):

    44

        if self.held:

    45

            self.held = 0

    46

            try:

    47

                os.unlink(self.f)

    48

            except: pass

    49