mercurial-crew-with-dirclash: templates/filelog.tmpl@d45d1c90032e (annotated)

Fix zombie files in merge # HG changeset patch # User maf46@burn.cl.cam.ac.uk # Node ID 57667c9b93a5a743e4629d15a0e6bd76699130c3 # Parent d2994b5298fb20f87dc1d4747635b280db3c0526 Fix zombie files in merge Keir Fraser observed the following: > I made a small test case that illustrates the bug in merging changesets > with 'hg remove's in them: > > 1. Create a repository A containing files foo & bar. > 2. Create clone called B. > 3. A removes file bar, and commits this removal. > 4. B edits file foo, and commits this edit. > > Now, if B: > # hg pull ../A; hg update -m; hg commit > Then bar remains deleted. > > If A: > # hg pull ../B; hg update -m; hg commit > Then bar is resurrected! > > It looks as though, when you merge across a branch, any deletions in > your own branch are forgotten. > ... > Fixing this is a must, as zombie files are a real pain. :-) Keir later patched our local copy of hg as shown below, which fixes the problem. I've also enclosed a test which captures the test Keir outlined... Files deleted on a branch should not automatically reappear in a merge Patch notes: 1. The first chunk does not change behaviour, but cleans up the code to more closely match check of 'force' in the second chunk. I think it makes the code clearer. 2. The second chunk fixes two bugs -- i. If we choose to keep a remotely-changed locally-deleted file, then we need to 'get' that file. If we choose to delete it then no action need be taken (it is already deleted in the working manifest). Without this fix, choosing to delete would get a Python traceback. ii. The test for whether the file was remotely-created is insufficient. It is only true if f is not in the common ancestor. Otherwise the file was deleted locally, and should remain deleted. (this is the most important fix!) Index: hg/tests/test-merge6 ===================================================================

142 529bf610092e Prettify the web interface mpm@selenic.com parents: 138 diff changeset	1	#header#
201 f918a6fa2572 hgweb: add template filters, template style maps, and raw pages mpm@selenic.com parents: 168 diff changeset	2	<title>#repo\|escape#: #file# history</title>
142 529bf610092e Prettify the web interface mpm@selenic.com parents: 138 diff changeset	3	</head>
138 c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	4	<body>
c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	5
154 1d5f799ebe1e fixed problem with head/body tags, added dtd, fixed table attributes jake@edge2.net parents: 153 diff changeset	6	<div class="buttons">
138 c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	7	<a href="?cmd=changelog">changelog</a>
168 65cf1b0cfe86 hgweb: add tags links and manifest links mpm@selenic.com parents: 155 diff changeset	8	<a href="?cmd=tags">tags</a>
153 e8a360cd5a9f changed pos to rev for changelog cmd, changed & to ; jake@edge2.net parents: 142 diff changeset	9	<a href="?cmd=file;file=#file#;filenode=#filenode#">file</a>
e8a360cd5a9f changed pos to rev for changelog cmd, changed & to ; jake@edge2.net parents: 142 diff changeset	10	<a href="?cmd=annotate;file=#file#;filenode=#filenode#">annotate</a>
599 765182a4c843 [PATCH] Add RSS support to hgweb mpm@selenic.com parents: 201 diff changeset	11	<a href="?cmd=filelog;file=#file#;filenode=0;style=rss">rss</a>
142 529bf610092e Prettify the web interface mpm@selenic.com parents: 138 diff changeset	12	</div>
138 c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	13
c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	14	<h2>#file# revision history</h2>
c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	15
c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	16	#entries#
c77a679e9cfa Revamped templated hgweb mpm@selenic.com parents: diff changeset	17
142 529bf610092e Prettify the web interface mpm@selenic.com parents: 138 diff changeset	18	#footer#

author	maf46@burn.cl.cam.ac.uk
	Mon, 04 Jul 2005 12:38:34 -0800
changeset 616	d45d1c90032e
parent 599	765182a4c843
child 661	148f642d1f8e
permissions	-rw-r--r--