comparison hgext/bugzilla.py @ 2221:05b6c13f43c6

reverse sense of return value from python hooks. old scheme (False/None/0/'' == fail) made coding style unnatural, did not allow use of mercurial commands as hooks. new scheme (False/None/0 == pass) is pythonic, does not require peculiar "return True" at ends of hooks, allows hooks like this: [hooks] # update working dir after push into this repo changegroup.update = python:mercurial.commands.update
author Vadim Gelfer <vadim.gelfer@gmail.com>
date Mon, 08 May 2006 10:59:58 -0700
parents ec82cff7d2c4
children 5e5adc1910ed
comparison
equal deleted inserted replaced
2220:6d3cc2a982f3 2221:05b6c13f43c6
276 ids = bz.find_bug_ids(bin_node, changes[4]) 276 ids = bz.find_bug_ids(bin_node, changes[4])
277 if ids: 277 if ids:
278 for id in ids: 278 for id in ids:
279 bz.update(id, bin_node, changes) 279 bz.update(id, bin_node, changes)
280 bz.notify(ids) 280 bz.notify(ids)
281 return True
282 except MySQLdb.MySQLError, err: 281 except MySQLdb.MySQLError, err:
283 raise util.Abort(_('database error: %s') % err[1]) 282 raise util.Abort(_('database error: %s') % err[1])
284 283