diff hgext/bugzilla.py @ 2221:05b6c13f43c6

reverse sense of return value from python hooks. old scheme (False/None/0/'' == fail) made coding style unnatural, did not allow use of mercurial commands as hooks. new scheme (False/None/0 == pass) is pythonic, does not require peculiar "return True" at ends of hooks, allows hooks like this: [hooks] # update working dir after push into this repo changegroup.update = python:mercurial.commands.update
author Vadim Gelfer <vadim.gelfer@gmail.com>
date Mon, 08 May 2006 10:59:58 -0700
parents ec82cff7d2c4
children 5e5adc1910ed
line wrap: on
line diff
--- a/hgext/bugzilla.py
+++ b/hgext/bugzilla.py
@@ -278,7 +278,6 @@ def hook(ui, repo, hooktype, node=None, 
             for id in ids:
                 bz.update(id, bin_node, changes)
             bz.notify(ids)
-        return True
     except MySQLdb.MySQLError, err:
         raise util.Abort(_('database error: %s') % err[1])