Mercurial > hg > mercurial-crew-with-dirclash
diff mercurial/hg.py @ 2579:0875cda033fd
use __contains__, index or split instead of str.find
str.find return -1 when the substring is not found, -1 evaluate
to True and is a valid index, which can lead to bugs.
Using alternatives when possible makes the code clearer and less
prone to bugs. (and __contains__ is faster in microbenchmarks)
author | Benoit Boissinot <benoit.boissinot@ens-lyon.org> |
---|---|
date | Sun, 09 Jul 2006 01:30:30 +0200 |
parents | d6605381c6df |
children | edb66cb05ded |
line wrap: on
line diff
--- a/mercurial/hg.py +++ b/mercurial/hg.py @@ -61,8 +61,7 @@ def repository(ui, path=None, create=0): if not path: path = '' scheme = path if scheme: - c = scheme.find(':') - scheme = c >= 0 and scheme[:c] + scheme = scheme.split(":", 1)[0] ctor = schemes.get(scheme) or schemes['file'] if create: try: