view tests/test-remove.out @ 5192:33015dac5df5

convert: fix mercurial_sink.putcommit Changeset 4ebc8693ce72 added some code to putcommit to avoid creating a revision that touches no files, but this can break regular conversions from some repositories: - conceptually, since we're converting a repo, we should try to make the new hg repo as similar as possible to the original repo - we should create a new changeset, even if the original revision didn't touch any files (maybe the commit message had some important bit); - even if a "regular" revision that doesn't touch any file may seem weird (and maybe even broken), it's completely legitimate for a merge revision to not touch any file, and, if we just skip it, the converted repo will end up with wrong history and possibly an extra head. As an example, say the crew and main hg repos are sync'ed. Somebody sends an important patch to the mailing list. Matt quickly applies and pushes it. But at the same time somebody also applies it to crew and pushes it. Suppose the commit message ended up being a bit different (say, there was a typo and somebody didn't fix it) or that the date ended up being different (because of different patch-applying scripts): the changeset hashes will be different, but the manifests will be the same. Since both changesets were pushed to public repos, it's hard to recall them. If both are merged, the manifest from the resulting merge revision will have the exact same contents as its parents - i.e. the merge revision really doesn't touch any file at all. To keep the file filtering stuff "working", the generic code was changed to skip empty revisions if we're filtering the repo, fixing a bug in the process (we want parents[0] instead of tip).
author Alexis S. L. Carvalho <alexis@cecm.usp.br>
date Fri, 17 Aug 2007 20:18:05 -0300
parents a6436e9333db
children
line wrap: on
line source

not removing foo: file is not managed
abort: no files specified
undeleting foo
removing foo
# HG changeset patch
# User test
# Date 1000000 0
# Node ID 8ba83d44753d6259db5ce6524974dd1174e90f47
# Parent  0000000000000000000000000000000000000000
1

diff -r 000000000000 -r 8ba83d44753d foo
--- /dev/null
+++ b/foo
@@ -0,0 +1,1 @@
+a
# HG changeset patch
# User test
# Date 1000000 0
# Node ID a1fce69c50d97881c5c014ab23f580f720c78678
# Parent  8ba83d44753d6259db5ce6524974dd1174e90f47
2

diff -r 8ba83d44753d -r a1fce69c50d9 foo
--- a/foo
+++ /dev/null
@@ -1,1 +0,0 @@
-a
changeset:   0:8ba83d44753d
user:        test
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     1

diff -r 000000000000 -r 8ba83d44753d foo
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/foo	Mon Jan 12 13:46:40 1970 +0000
@@ -0,0 +1,1 @@
+a

changeset:   1:a1fce69c50d9
tag:         tip
user:        test
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     2

diff -r 8ba83d44753d -r a1fce69c50d9 foo
--- a/foo	Mon Jan 12 13:46:40 1970 +0000
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,1 +0,0 @@
-a

not removing a: file has been marked for add (use -f to force removal)
adding a
adding b
adding c/d
not removing b: file is modified (use -f to force removal)
R b
R c/d
d
undeleting c/d
R b
R b
removing c/d
R b
R c/d
3 files updated, 0 files merged, 0 files removed, 0 files unresolved