[PATCH] Harden os.system -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [PATCH] Harden os.system From: Bryan O'Sullivan <bos@serpentine.com> Add util.system function. This is similar to os.system, but will either succeed (if the process finishes with a zero exit code) or raise a util.CommandError (if the process exits uncleanly or is killed by a signal). Add util.explain_exit function. This tends to be ubiquitous in code that calls other processes, and must describe what has gone wrong. Change some uses of os.system over to util.system. manifest hash: e3bf4adcac5b915432ec0af00efdbcef86bea4b1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) iD8DBQFCwSipywK+sNU5EO8RAr0RAJkBDt8XQ7mYQAWNHNgTOVt1eyWU1QCfe1oO 2OwxyWqpbRNACVJHHfZ3/Xw= =OaRX -----END PGP SIGNATURE-----

+ hg clone http://localhost:20059/ copy
requesting all changes
adding changesets
abort: error 111: Connection refused
transaction abort!
failed to truncate 00changelog.d
failed to truncate 00changelog.i
rollback completed
+ echo 255
255
+ ls copy
ls: copy: No such file or directory
+ cat
+ python dumb.py
+ hg clone http://localhost:20059/foo copy2
requesting all changes
adding changesets
abort: HTTP Error 404: File not found
transaction abort!
failed to truncate 00changelog.d
failed to truncate 00changelog.i
rollback completed
+ echo 255
255
+ set +x