view tests/test-committer.out @ 4095:6fa7a2d0fc2e

hgweb: catch util.Abort raised by addchangegroup Right now, if a pretxnchangegroup hook fails, we send some HTML error message to the client and the transaction is not rolled back (issue499). Catching util.Abort allows us to send a decent message to the client and for some reason makes the rollback complete. This patch is not perfect since it doesn't fix the reason why the transaction wasn't rolled back (maybe some circular references?). Also, the transaction is aborted only after we've sent the response back to the client and the "transaction aborted" message ends up in the logs of the web server.
author Alexis S. L. Carvalho <alexis@cecm.usp.br>
date Fri, 16 Feb 2007 05:10:43 -0200
parents 78a0dd93db0b
children 5c5d23d93447
line wrap: on
line source

changeset:   0:9426b370c206
tag:         tip
user:        My Name <myname@example.com>
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     commit-1

changeset:   1:4997f15a1b24
tag:         tip
user:        foo@bar.com
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     commit-1

changeset:   2:72b8012b424e
tag:         tip
user:        foobar <foo@bar.com>
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     commit-1

changeset:   3:35ff3067bedd
tag:         tip
user:        foo@bar.com
date:        Mon Jan 12 13:46:40 1970 +0000
summary:     commit-1

abort: Please specify a username.
transaction abort!
rollback completed
No username found, using user@host instead