annotate src/core/ngx_murmurhash.h @ 4964:2464ccebdb52
Upstream: fixed SIGSEGV with the "if" directive.
Configuration like
location / {
set $true 1;
if ($true) {
proxy_pass http://backend;
}
if ($true) {
# nothing
}
}
resulted in segmentation fault due to NULL pointer dereference as the
upstream configuration wasn't initialized in an implicit location created
by the last if(), but the r->content_handler was set due to first if().
Instead of committing a suicide by dereferencing a NULL pointer, return
500 (Internal Server Error) in such cases, i.e. if uscf is NULL. Better
fix would be to avoid such cases by fixing the "if" directive handling,
but it's out of scope of this patch.
Prodded by Piotr Sikora.
| author |
Maxim Dounin <mdounin@mdounin.ru> |
| date |
Thu, 13 Dec 2012 16:05:59 +0000 |
| parents |
709d7d24239d |
| children |
|
| rev |
line source |
|
3891
|
1
|
|
|
2 /*
|
|
|
3 * Copyright (C) Igor Sysoev
|
|
4412
|
4 * Copyright (C) Nginx, Inc.
|
|
3891
|
5 */
|
|
|
6
|
|
|
7
|
|
|
8 #ifndef _NGX_MURMURHASH_H_INCLUDED_
|
|
|
9 #define _NGX_MURMURHASH_H_INCLUDED_
|
|
|
10
|
|
|
11
|
|
|
12 #include <ngx_config.h>
|
|
|
13 #include <ngx_core.h>
|
|
|
14
|
|
|
15
|
|
|
16 uint32_t ngx_murmur_hash2(u_char *data, size_t len);
|
|
|
17
|
|
|
18
|
|
4575
|
19 #endif /* _NGX_MURMURHASH_H_INCLUDED_ */
|
