annotate contrib/README @ 6833:3834951e32ab

HTTP/2: fixed posted streams handling. A bug was introduced by 82efcedb310b that could lead to timing out of responses or segmentation fault, when accept_mutex was enabled. The output queue in HTTP/2 can contain frames from different streams. When the queue is sent, all related write handlers need to be called. In order to do so, the streams were added to the h2c->posted queue after handling sent frames. Then this queue was processed in ngx_http_v2_write_handler(). If accept_mutex is enabled, the event's "ready" flag is set but its handler is not called immediately. Instead, the event is added to the ngx_posted_events queue. At the same time in this queue can be events from upstream connections. Such events can result in sending output queue before ngx_http_v2_write_handler() is triggered. And at the time ngx_http_v2_write_handler() is called, the output queue can be already empty with some streams added to h2c->posted. But after 82efcedb310b, these streams weren't processed if all frames have already been sent and the output queue was empty. This might lead to a situation when a number of streams were get stuck in h2c->posted queue for a long time. Eventually these streams might get closed by the send timeout. In the worst case this might also lead to a segmentation fault, if already freed stream was left in the h2c->posted queue. This could happen if one of the streams was terminated but wasn't closed, due to the HEADERS frame or a partially sent DATA frame left in the output queue. If this happened the ngx_http_v2_filter_cleanup() handler removed the stream from the h2c->waiting or h2c->posted queue on termination stage, before the frame has been sent, and the stream was again added to the h2c->posted queue after the frame was sent. In order to fix all these problems and simplify the code, write events of fake stream connections are now added to ngx_posted_events instead of using a custom h2c->posted queue.
author Valentin Bartenev <vbart@nginx.com>
date Mon, 28 Nov 2016 20:58:14 +0300
parents 1bdf906bba99
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
537
c9ad0d9c7d59 nginx-0.1.43-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
1
667
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
2 geo2nginx.pl by Andrei Nigmatulin
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
3
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
4 The perl script to convert CSV geoip database ( free download
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
5 at http://www.maxmind.com/app/geoip_country ) to format, suitable
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
6 for use by the ngx_http_geo_module.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
7
537
c9ad0d9c7d59 nginx-0.1.43-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
8
667
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
9 unicode2nginx by Maxim Dounin
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
10
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
11 The perl script to convert unicode mappings ( available
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
12 at http://www.unicode.org/Public/MAPPINGS/ ) to the nginx
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
13 configuration file format.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
14 Two generated full maps for windows-1251 and koi8-r.
63a820b0bc6c nginx-0.3.55-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents: 537
diff changeset
15
5461
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
16
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
17 vim by Evan Miller
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
18
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
19 Syntax highlighting of nginx configuration for vim, to be
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
20 placed into ~/.vim/.
1bdf906bba99 Contrib: added vim to README.
Maxim Dounin <mdounin@mdounin.ru>
parents: 667
diff changeset
21