annotate src/event/ngx_event_udp.h @ 8867:5119c8150478

Fixed runtime handling of systems without EPOLLRDHUP support. In 7583:efd71d49bde0 (nginx 1.17.5) along with introduction of the ioctl(FIONREAD) support proper handling of systems without EPOLLRDHUP support in the kernel (but with EPOLLRDHUP in headers) was broken. Before the change, rev->available was never set to 0 unless ngx_use_epoll_rdhup was also set (that is, runtime test for EPOLLRDHUP introduced in 6536:f7849bfb6d21 succeeded). After the change, rev->available might reach 0 on systems without runtime EPOLLRDHUP support, stopping further reading in ngx_readv_chain() and ngx_unix_recv(). And, if EOF happened to be already reported along with the last event, it is not reported again by epoll_wait(), leading to connection hangs and timeouts on such systems. This affects Linux kernels before 2.6.17 if nginx was compiled with newer headers, and, more importantly, emulation layers, such as DigitalOcean's App Platform's / gVisor's epoll emulation layer. Fix is to explicitly check ngx_use_epoll_rdhup before the corresponding rev->pending_eof tests in ngx_readv_chain() and ngx_unix_recv().
author Marcus Ball <marcus.ball@live.com>
date Mon, 30 May 2022 02:38:07 +0300
parents 0f6cc8f73744
children ce6d9cf0f567
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
8838
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
1
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
2 /*
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
3 * Copyright (C) Nginx, Inc.
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
4 */
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
5
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
6
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
7 #ifndef _NGX_EVENT_UDP_H_INCLUDED_
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
8 #define _NGX_EVENT_UDP_H_INCLUDED_
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
9
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
10
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
11 #include <ngx_config.h>
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
12 #include <ngx_core.h>
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
13
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
14
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
15 #if !(NGX_WIN32)
8839
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
16
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
17 #if ((NGX_HAVE_MSGHDR_MSG_CONTROL) \
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
18 && (NGX_HAVE_IP_SENDSRCADDR || NGX_HAVE_IP_RECVDSTADDR \
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
19 || NGX_HAVE_IP_PKTINFO \
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
20 || (NGX_HAVE_INET6 && NGX_HAVE_IPV6_RECVPKTINFO)))
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
21 #define NGX_HAVE_ADDRINFO_CMSG 1
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
22
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
23 #endif
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
24
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
25
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
26 #if (NGX_HAVE_ADDRINFO_CMSG)
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
27
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
28 typedef union {
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
29 #if (NGX_HAVE_IP_SENDSRCADDR || NGX_HAVE_IP_RECVDSTADDR)
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
30 struct in_addr addr;
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
31 #endif
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
32
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
33 #if (NGX_HAVE_IP_PKTINFO)
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
34 struct in_pktinfo pkt;
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
35 #endif
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
36
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
37 #if (NGX_HAVE_INET6 && NGX_HAVE_IPV6_RECVPKTINFO)
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
38 struct in6_pktinfo pkt6;
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
39 #endif
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
40 } ngx_addrinfo_t;
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
41
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
42 size_t ngx_set_srcaddr_cmsg(struct cmsghdr *cmsg,
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
43 struct sockaddr *local_sockaddr);
8840
0f6cc8f73744 Core: added function for local source address cmsg.
Vladimir Homutov <vl@nginx.com>
parents: 8839
diff changeset
44 ngx_int_t ngx_get_srcaddr_cmsg(struct cmsghdr *cmsg,
0f6cc8f73744 Core: added function for local source address cmsg.
Vladimir Homutov <vl@nginx.com>
parents: 8839
diff changeset
45 struct sockaddr *local_sockaddr);
8839
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
46
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
47 #endif
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
48
8838
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
49 void ngx_event_recvmsg(ngx_event_t *ev);
8839
cfe1284e5d1d Core: made the ngx_sendmsg() function non-static.
Vladimir Homutov <vl@nginx.com>
parents: 8838
diff changeset
50 ssize_t ngx_sendmsg(ngx_connection_t *c, struct msghdr *msg, int flags);
8838
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
51 void ngx_udp_rbtree_insert_value(ngx_rbtree_node_t *temp,
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
52 ngx_rbtree_node_t *node, ngx_rbtree_node_t *sentinel);
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
53 #endif
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
54
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
55 void ngx_delete_udp_connection(void *data);
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
56
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
57
8206ecdcd837 Core: the ngx_event_udp.h header file.
Vladimir Homutov <vl@nginx.com>
parents:
diff changeset
58 #endif /* _NGX_EVENT_UDP_H_INCLUDED_ */