annotate docs/html/50x.html @ 6909:5850fed24639

Upstream: read handler cleared on upstream finalization. With "proxy_ignore_client_abort off" (the default), upstream module changes r->read_event_handler to ngx_http_upstream_rd_check_broken_connection(). If the handler is not cleared during upstream finalization, it can be triggered later, causing unexpected effects, if, for example, a request was redirected to a different location using error_page or X-Accel-Redirect. In particular, it makes "proxy_ignore_client_abort on" non-working after a redirection in a configuration like this: location = / { error_page 502 = /error; proxy_pass http://127.0.0.1:8082; } location /error { proxy_pass http://127.0.0.1:8083; proxy_ignore_client_abort on; } It is also known to cause segmentation faults with aio used, see http://mailman.nginx.org/pipermail/nginx-ru/2015-August/056570.html. Fix is to explicitly set r->read_event_handler to ngx_http_block_reading() during upstream finalization, similar to how it is done in the request body reading code and in the limit_req module.
author Maxim Dounin <mdounin@mdounin.ru>
date Fri, 10 Feb 2017 20:24:26 +0300
parents b5ba6f22a0fc
children 1cd63ae46243
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4840
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
1 <!DOCTYPE html>
657
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
2 <html>
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
3 <head>
4840
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
4 <title>Error</title>
657
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
5 <style>
4840
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
6 body {
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
7 width: 35em;
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
8 margin: 0 auto;
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
9 font-family: Tahoma, Verdana, Arial, sans-serif;
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
10 }
657
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
11 </style>
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
12 </head>
4840
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
13 <body>
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
14 <h1>An error occurred.</h1>
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
15 <p>Sorry, the page you are looking for is currently unavailable.<br/>
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
16 Please try again later.</p>
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
17 <p>If you are the system administrator of this resource then you should check
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
18 the <a href="http://nginx.org/r/error_log">error log</a> for details.</p>
b5ba6f22a0fc Improved 50x error page.
Valentin Bartenev <vbart@nginx.com>
parents: 663
diff changeset
19 <p><em>Faithfully yours, nginx.</em></p>
657
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
20 </body>
400711951595 nginx-0.3.50-RELEASE import
Igor Sysoev <igor@sysoev.ru>
parents:
diff changeset
21 </html>