annotate contrib/README @ 4147:7f64de1cc2c0
Fix for double content when return is used in error_page handler.
Test case:
location / {
error_page 405 /nope;
return 405;
}
location /nope {
return 200;
}
This is expected to return 405 with empty body, but in 0.8.42+ will return
builtin 405 error page as well (though not counted in Content-Length, thus
breaking protocol).
Fix is to use status provided by rewrite script execution in case
it's less than NGX_HTTP_BAD_REQUEST even if r->error_status set. This
check is in line with one in ngx_http_script_return_code().
Note that this patch also changes behaviour for "return 302 ..." and
"rewrite ... redirect" used as error handler. E.g.
location / {
error_page 405 /redirect;
return 405;
}
location /redirect {
rewrite ^ http://example.com/;
}
will actually return redirect to "http://example.com/" instead of builtin 405
error page with meaningless Location header. This looks like correct change
and it's in line with what happens on e.g. directory redirects in error
handlers.
author |
Maxim Dounin <mdounin@mdounin.ru> |
date |
Tue, 27 Sep 2011 11:11:30 +0000 |
parents |
63a820b0bc6c |
children |
1bdf906bba99 |
rev |
line source |
537
|
1
|
667
|
2 geo2nginx.pl by Andrei Nigmatulin
|
|
3
|
|
4 The perl script to convert CSV geoip database ( free download
|
|
5 at http://www.maxmind.com/app/geoip_country ) to format, suitable
|
|
6 for use by the ngx_http_geo_module.
|
|
7
|
537
|
8
|
667
|
9 unicode2nginx by Maxim Dounin
|
|
10
|
|
11 The perl script to convert unicode mappings ( available
|
|
12 at http://www.unicode.org/Public/MAPPINGS/ ) to the nginx
|
|
13 configuration file format.
|
|
14 Two generated full maps for windows-1251 and koi8-r.
|
|
15
|