Mercurial > hg > nginx-quic
annotate conf/fastcgi_params @ 6359:dac6eda40475 stable-1.8
Resolver: fixed use-after-free memory accesses with CNAME.
When several requests were waiting for a response, then after getting
a CNAME response only the last request's context had the name updated.
Contexts of other requests had the wrong name. This name was used by
ngx_resolve_name_done() to find the node to remove the request context
from. When the name was wrong, the request could not be properly
cancelled, its context was freed but stayed linked to the node's waiting
list. This happened e.g. when the first request was aborted or timed
out before the resolving completed. When it completed, this triggered
a use-after-free memory access by calling ctx->handler of already freed
request context. The bug manifests itself by
"could not cancel <name> resolving" alerts in error_log.
When a request was responded with a CNAME, the request context kept
the pointer to the original node's rn->u.cname. If the original node
expired before the resolving timed out or completed with an error,
this would trigger a use-after-free memory access via ctx->name in
ctx->handler().
The fix is to keep ctx->name unmodified. The name from context
is no longer used by ngx_resolve_name_done(). Instead, we now keep
the pointer to resolver node to which this request is linked.
Keeping the original name intact also improves logging.
author | Roman Arutyunyan <arut@nginx.com> |
---|---|
date | Tue, 26 Jan 2016 16:46:59 +0300 |
parents | 352a7b025f2e |
children | 62869a9b2e7d |
rev | line source |
---|---|
537 | 1 |
2 fastcgi_param QUERY_STRING $query_string; | |
3 fastcgi_param REQUEST_METHOD $request_method; | |
4 fastcgi_param CONTENT_TYPE $content_type; | |
5 fastcgi_param CONTENT_LENGTH $content_length; | |
6 | |
7 fastcgi_param SCRIPT_NAME $fastcgi_script_name; | |
8 fastcgi_param REQUEST_URI $request_uri; | |
9 fastcgi_param DOCUMENT_URI $document_uri; | |
10 fastcgi_param DOCUMENT_ROOT $document_root; | |
11 fastcgi_param SERVER_PROTOCOL $server_protocol; | |
4333
352a7b025f2e
Added HTTPS param with Apache-like behaviour to fastcgi/scgi/uwsgi_params (fixes #38).
Valentin Bartenev <vbart@nginx.com>
parents:
1330
diff
changeset
|
12 fastcgi_param HTTPS $https if_not_empty; |
537 | 13 |
14 fastcgi_param GATEWAY_INTERFACE CGI/1.1; | |
1330 | 15 fastcgi_param SERVER_SOFTWARE nginx/$nginx_version; |
537 | 16 |
17 fastcgi_param REMOTE_ADDR $remote_addr; | |
18 fastcgi_param REMOTE_PORT $remote_port; | |
19 fastcgi_param SERVER_ADDR $server_addr; | |
20 fastcgi_param SERVER_PORT $server_port; | |
21 fastcgi_param SERVER_NAME $server_name; | |
22 | |
23 # PHP only, required if PHP was built with --enable-force-cgi-redirect | |
24 fastcgi_param REDIRECT_STATUS 200; |