diff src/http/modules/ngx_http_quic_module.c @ 8633:74b43926b470 quic

HTTP/3: fixed segfault when using SSL certificates with variables. A QUIC connection doesn't have c->log->data and friends initialized to sensible values. Yet, a request can be created in the certificate callback with such an assumption, which leads to a segmentation fault due to null pointer dereference in ngx_http_free_request(). The fix is to adjust initializing the QUIC part of a connection such that it has all of that in place. Further, this appends logging error context for unsuccessful QUIC handshakes: - cannot load certificate .. while handling frames - SSL_do_handshake() failed .. while sending frames
author Sergey Kandaurov <pluknet@nginx.com>
date Wed, 29 Sep 2021 15:01:59 +0300
parents 59d2d47ad3c6
children 4b2d259bdadd
line wrap: on
line diff
--- a/src/http/modules/ngx_http_quic_module.c
+++ b/src/http/modules/ngx_http_quic_module.c
@@ -198,8 +198,6 @@ ngx_http_quic_init(ngx_connection_t *c)
     hc->ssl = 1;
 
     if (c->quic == NULL) {
-        c->log->connection = c->number;
-
         qcf = ngx_http_get_module_srv_conf(hc->conf_ctx, ngx_http_quic_module);
 
         ngx_quic_run(c, qcf);