Mercurial > hg > nginx-quic
view docs/dtd/change_log_conf.dtd @ 4147:7f64de1cc2c0
Fix for double content when return is used in error_page handler.
Test case:
location / {
error_page 405 /nope;
return 405;
}
location /nope {
return 200;
}
This is expected to return 405 with empty body, but in 0.8.42+ will return
builtin 405 error page as well (though not counted in Content-Length, thus
breaking protocol).
Fix is to use status provided by rewrite script execution in case
it's less than NGX_HTTP_BAD_REQUEST even if r->error_status set. This
check is in line with one in ngx_http_script_return_code().
Note that this patch also changes behaviour for "return 302 ..." and
"rewrite ... redirect" used as error handler. E.g.
location / {
error_page 405 /redirect;
return 405;
}
location /redirect {
rewrite ^ http://example.com/;
}
will actually return redirect to "http://example.com/" instead of builtin 405
error page with meaningless Location header. This looks like correct change
and it's in line with what happens on e.g. directory redirects in error
handlers.
author | Maxim Dounin <mdounin@mdounin.ru> |
---|---|
date | Tue, 27 Sep 2011 11:11:30 +0000 |
parents | 551102312e19 |
children |
line wrap: on
line source
<!ELEMENT configuration (length, start, indent, changes+) > <!ELEMENT length (#PCDATA) > <!ELEMENT start (#PCDATA) > <!ELEMENT indent (#PCDATA) > <!ELEMENT changes (title, length, bugfix, feature, change, workaround, (month, month, month, month, month, month, month, month, month, month, month, month)?) > <!ATTLIST changes lang ( ru | en) #REQUIRED> <!ELEMENT title (#PCDATA) > <!ELEMENT bugfix (#PCDATA) > <!ELEMENT feature (#PCDATA) > <!ELEMENT change (#PCDATA) > <!ELEMENT workaround (#PCDATA) > <!ELEMENT month (#PCDATA) >