view auto/lib/zlib/makefile.owc @ 6627:ad736705a744

HTTP/2: avoid left-shifting signed integer into the sign bit. On non-aligned platforms, properly cast argument before left-shifting it in ngx_http_v2_parse_uint32 that is used with u_char. Otherwise it propagates to int to hold the value and can step over the sign bit. Usually, on known compilers, this results in negation. Furthermore, a subsequent store into a wider type, that is ngx_uint_t on 64-bit platforms, results in sign-extension. In practice, this can be observed in debug log as a very large exclusive bit value, when client sent PRIORITY frame with exclusive bit set: : *14 http2 PRIORITY frame sid:5 on 1 excl:8589934591 weight:17 Found with UndefinedBehaviorSanitizer.
author Sergey Kandaurov <pluknet@nginx.com>
date Thu, 07 Jul 2016 21:03:21 +0300
parents 9d458803bbe0
children
line wrap: on
line source


# Copyright (C) Igor Sysoev
# Copyright (C) Nginx, Inc.


CFLAGS = -zq -bt=nt -ot -op -oi -oe -s -bm $(CPU_OPT)

zlib.lib:
	cd $(ZLIB)

	wcl386 -c $(CFLAGS) adler32.c crc32.c deflate.c trees.c zutil.c &
		compress.c inflate.c inffast.c inftrees.c
	wlib -n zlib.lib adler32.obj crc32.obj deflate.obj trees.obj &
		zutil.obj compress.obj inflate.obj inffast.obj inftrees.obj