Mercurial > hg > nginx-quic
view src/misc/ngx_cpp_test_module.cpp @ 9075:b71e69247483 default
Variables: avoid possible buffer overrun with some "$sent_http_*".
The existing logic to evaluate multi header "$sent_http_*" variables,
such as $sent_http_cache_control, as previously introduced in 1.23.0,
doesn't take into account that one or more elements can be cleared,
yet still present in a linked list, pointed to by the next field.
Such elements don't contribute to the resulting variable length, an
attempt to append a separator for them ends up in out of bounds write.
This is not possible with standard modules, though at least one third
party module is known to override multi header values this way, so it
makes sense to harden the logic.
The fix restores a generic boundary check.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Mon, 01 May 2023 19:16:05 +0400 |
parents | f1e6f65ddfeb |
children |
line wrap: on
line source
// stub module to test header files' C++ compatibility extern "C" { #include <ngx_config.h> #include <ngx_core.h> #include <ngx_event.h> #include <ngx_event_connect.h> #include <ngx_event_pipe.h> #include <ngx_http.h> #include <ngx_mail.h> #include <ngx_mail_pop3_module.h> #include <ngx_mail_imap_module.h> #include <ngx_mail_smtp_module.h> #include <ngx_stream.h> } // nginx header files should go before other, because they define 64-bit off_t // #include <string> void ngx_cpp_test_handler(void *data); void ngx_cpp_test_handler(void *data) { return; }