Mercurial > hg > nginx-quic
view src/mail/ngx_mail_smtp_module.h @ 7629:f47f7d3d1bfa
Mp4: fixed possible chunk offset overflow.
In "co64" atom chunk start offset is a 64-bit unsigned integer. When trimming
the "mdat" atom, chunk offsets are casted to off_t values which are typically
64-bit signed integers. A specially crafted mp4 file with huge chunk offsets
may lead to off_t overflow and result in negative trim boundaries.
The consequences of the overflow are:
- Incorrect Content-Length header value in the response.
- Negative left boundary of the response file buffer holding the trimmed "mdat".
This leads to pread()/sendfile() errors followed by closing the client
connection.
On rare systems where off_t is a 32-bit integer, this scenario is also feasible
with the "stco" atom.
The fix is to add checks which make sure data chunks referenced by each track
are within the mp4 file boundaries. Additionally a few more checks are added to
ensure mp4 file consistency and log errors.
| author | Roman Arutyunyan <arut@nginx.com> |
|---|---|
| date | Wed, 26 Feb 2020 15:10:46 +0300 |
| parents | d620f497c50f |
| children |
line wrap: on
line source
/* * Copyright (C) Igor Sysoev * Copyright (C) Nginx, Inc. */ #ifndef _NGX_MAIL_SMTP_MODULE_H_INCLUDED_ #define _NGX_MAIL_SMTP_MODULE_H_INCLUDED_ #include <ngx_config.h> #include <ngx_core.h> #include <ngx_mail.h> #include <ngx_mail_smtp_module.h> typedef struct { ngx_msec_t greeting_delay; size_t client_buffer_size; ngx_str_t capability; ngx_str_t starttls_capability; ngx_str_t starttls_only_capability; ngx_str_t server_name; ngx_str_t greeting; ngx_uint_t auth_methods; ngx_array_t capabilities; } ngx_mail_smtp_srv_conf_t; void ngx_mail_smtp_init_session(ngx_mail_session_t *s, ngx_connection_t *c); void ngx_mail_smtp_init_protocol(ngx_event_t *rev); void ngx_mail_smtp_auth_state(ngx_event_t *rev); ngx_int_t ngx_mail_smtp_parse_command(ngx_mail_session_t *s); extern ngx_module_t ngx_mail_smtp_module; #endif /* _NGX_MAIL_SMTP_MODULE_H_INCLUDED_ */