annotate binary_upgrade.t @ 1571:1b4ceab9cb1c

Tests: fixed ssl_certificate.t with LibreSSL client. Net::SSLeay::connect() that manages TLS handshake could return unexpected error when receiving server alert, as seen in server certificate tests if it could not been selected. Typically, it returns the expected error -1, but with certain libssl implementations it can be 0, as explained below. The error is propagated from libssl's SSL_connect(), which is usually -1. In modern OpenSSL versions, it is the default error code used in the state machine returned when something went wrong with parsing TLS message header. In versions up to OpenSSL 1.0.2, with SSLv23_method() used by default, -1 is the only error code in the ssl_connect() method implementation which is used as well if receiving alert while parsing ServerHello. BoringSSL also seems to return -1. But it is not so with LibreSSL that returns zero. Previously, tests failed with client built with LibreSSL with SSLv3 removed. Here, the error is propagated directly from ssl_read_bytes() method, which is always implemented as ssl3_read_bytes() in all TLS methods. It could be also seen with OpenSSL up to 1.0.2 with non-default methods explicitly set.
author Sergey Kandaurov <pluknet@nginx.com>
date Fri, 29 May 2020 23:10:20 +0300
parents fe60c3959069
children d7e83ce613c2
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1254
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
1 #!/usr/bin/perl
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
2
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
3 # (C) Sergey Kandaurov
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
4 # (C) Nginx, Inc.
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
5
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
6 # Tests for binary upgrade.
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
7
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
8 ###############################################################################
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
9
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
10 use warnings;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
11 use strict;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
12
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
13 use Test::More;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
14
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
15 BEGIN { use FindBin; chdir($FindBin::Bin); }
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
16
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
17 use lib 'lib';
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
18 use Test::Nginx;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
19
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
20 ###############################################################################
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
21
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
22 select STDERR; $| = 1;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
23 select STDOUT; $| = 1;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
24
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
25 plan(skip_all => 'can leave orphaned process group')
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
26 unless $ENV{TEST_NGINX_UNSAFE};
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
27
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
28 my $t = Test::Nginx->new()->plan(2)->write_file_expand('nginx.conf', <<'EOF');
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
29
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
30 %%TEST_GLOBALS%%
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
31
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
32 events {
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
33 }
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
34
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
35 EOF
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
36
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
37 $t->run();
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
38
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
39 ###############################################################################
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
40
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
41 my $pid = $t->read_file('nginx.pid');
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
42 ok($pid, 'master pid');
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
43
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
44 kill 'USR2', $pid;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
45
1332
fe60c3959069 Tests: adjusted binary_upgrade.t for instrumented binaries.
Sergey Kandaurov <pluknet@nginx.com>
parents: 1288
diff changeset
46 for (1 .. 30) {
1254
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
47 last if -e $t->testdir() . '/nginx.pid'
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
48 && -e $t->testdir() . '/nginx.pid.oldbin';
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
49 select undef, undef, undef, 0.2
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
50 }
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
51
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
52 isnt($t->read_file('nginx.pid'), $pid, 'master pid changed');
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
53
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
54 kill 'QUIT', $pid;
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
55
6fff42643fd7 Tests: binary upgrade.
Sergey Kandaurov <pluknet@nginx.com>
parents:
diff changeset
56 ###############################################################################