view auth_request_satisfy.t @ 1571:1b4ceab9cb1c

Tests: fixed ssl_certificate.t with LibreSSL client. Net::SSLeay::connect() that manages TLS handshake could return unexpected error when receiving server alert, as seen in server certificate tests if it could not been selected. Typically, it returns the expected error -1, but with certain libssl implementations it can be 0, as explained below. The error is propagated from libssl's SSL_connect(), which is usually -1. In modern OpenSSL versions, it is the default error code used in the state machine returned when something went wrong with parsing TLS message header. In versions up to OpenSSL 1.0.2, with SSLv23_method() used by default, -1 is the only error code in the ssl_connect() method implementation which is used as well if receiving alert while parsing ServerHello. BoringSSL also seems to return -1. But it is not so with LibreSSL that returns zero. Previously, tests failed with client built with LibreSSL with SSLv3 removed. Here, the error is propagated directly from ssl_read_bytes() method, which is always implemented as ssl3_read_bytes() in all TLS methods. It could be also seen with OpenSSL up to 1.0.2 with non-default methods explicitly set.
author Sergey Kandaurov <pluknet@nginx.com>
date Fri, 29 May 2020 23:10:20 +0300
parents 882267679006
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Maxim Dounin

# Tests for auth request module with satisfy directive.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()
	->has(qw/http rewrite access auth_basic auth_request/)
	->plan(18);

$t->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

http {
    %%TEST_GLOBALS_HTTP%%

    server {
        listen       127.0.0.1:8080;
        server_name  localhost;

        location / {
            return 444;
        }

        location /all/allow {
            satisfy all;
            allow all;
            auth_request /auth;
        }

        location /all/deny {
            satisfy all;
            deny all;
            auth_request /auth;
        }

        location /all/basic {
            satisfy all;
            auth_basic "restricted";
            auth_basic_user_file %%TESTDIR%%/htpasswd;
            auth_request /auth;
        }

        location /any/allow {
            satisfy any;
            allow all;
            auth_request /auth;
        }

        location /any/deny {
            satisfy any;
            deny all;
            auth_request /auth;
        }

        location /any/basic {
            satisfy any;
            auth_basic "restricted";
            auth_basic_user_file %%TESTDIR%%/htpasswd;
            auth_request /auth;
        }

        location = /auth {
            if ($request_uri ~ "open$") {
                return 204;
            }
            if ($request_uri ~ "unauthorized$") {
                return 401;
            }
            if ($request_uri ~ "forbidden$") {
                return 403;
            }
        }
    }
}

EOF

$t->write_file('htpasswd', 'user:{PLAIN}secret' . "\n");
$t->run();

###############################################################################

# satisfy all - first 401/403 wins

like(http_get('/all/allow+open'), qr/ 404 /, 'all allow+open');
like(http_get('/all/allow+unauthorized'), qr/ 401 /, 'all allow+unauthorized');
like(http_get('/all/allow+forbidden'), qr/ 403 /, 'all allow+forbidden');

like(http_get('/all/deny+open'), qr/ 403 /, 'all deny+open');
like(http_get('/all/deny+unauthorized'), qr/ 403 /, 'all deny+unauthorized');
like(http_get('/all/deny+forbidden'), qr/ 403 /, 'all deny+forbidden');

like(http_get('/all/basic+open'), qr/ 401 /, 'all basic+open');
like(http_get('/all/basic+unauthorized'), qr/ 401 /, 'all basic+unauthorized');
like(http_get('/all/basic+forbidden'), qr/ 401 /, 'all basic+forbidden');

# satisfy any - first ok wins
# additionally, 403 shouldn't override 401 status

like(http_get('/any/allow+open'), qr/ 404 /, 'any allow+open');
like(http_get('/any/allow+unauthorized'), qr/ 404 /, 'any allow+unauthorized');
like(http_get('/any/allow+forbidden'), qr/ 404 /, 'any allow+forbidden');

like(http_get('/any/deny+open'), qr/ 404 /, 'any deny+open');
like(http_get('/any/deny+unauthorized'), qr/ 401 /, 'any deny+unauthorized');
like(http_get('/any/deny+forbidden'), qr/ 403 /, 'any deny+forbidden');

like(http_get('/any/basic+open'), qr/ 404 /, 'any basic+open');
like(http_get('/any/basic+unauthorized'), qr/ 401 /, 'any basic+unauthorized');
like(http_get('/any/basic+forbidden'), qr/ 401 /, 'any basic+forbidden');

###############################################################################