Mercurial > hg > nginx-tests
view h2_limit_req.t @ 1752:ba6e24e38f03
Tests: improved stop_daemons() to send signal again.
As was observed, it's possible that a signal to complete a uwsgi daemon
can be ignored while it is starting up, which results in tests hang due
to eternal waiting on child processes termination. Notably, it is seen
when running tests with a high number of prove jobs on a low-profile VM
against nginx with broken modules and/or configuration. To reproduce:
$ TEST_NGINX_GLOBALS=ERROR prove -j16 uwsgi*.t
Inspecting uwsgi under ktrace on FreeBSD confirms that a SIGTERM signal
is ignored at the very beginning of uwsgi startup. It is then replaced
with a default action after listen(), thus waiting until uwsgi is ready
to accept new TCP connections doesn't completely solve the hang window.
The fix is to retry sending a signal some time after waitpid(WNOHANG)
continuously demonstrated no progress with reaping a signaled process.
It is modelled after f13ead27f89c that improved stop() for nginx.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Wed, 29 Dec 2021 22:29:23 +0300 |
parents | efc502e696b0 |
children | 9a44d489966c |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Tests for HTTP/2 protocol with limit_req. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::HTTP2; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http http_v2 proxy rewrite limit_req/) ->plan(7); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% limit_req_zone $binary_remote_addr zone=req:1m rate=1r/s; server { listen 127.0.0.1:8080 http2; listen 127.0.0.1:8081; server_name localhost; location / { } location /limit_req { limit_req zone=req burst=2; alias %%TESTDIR%%/t.html; } location /proxy_limit_req/ { add_header X-Body $request_body; add_header X-Body-File $request_body_file; client_body_in_file_only on; proxy_pass http://127.0.0.1:8081/; limit_req zone=req burst=2; } } } EOF $t->write_file('index.html', ''); $t->write_file('t.html', 'SEE-THIS'); $t->run(); ############################################################################### # request body delayed in limit_req my $s = Test::Nginx::HTTP2->new(); my $sid = $s->new_stream({ path => '/proxy_limit_req/', body_more => 1 }); $s->h2_body('TEST'); my $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); my ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is(read_body_file($frame->{headers}->{'x-body-file'}), 'TEST', 'request body - limit req'); $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/proxy_limit_req/', body_more => 1 }); select undef, undef, undef, 1.1; $s->h2_body('TEST'); $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is(read_body_file($frame->{headers}->{'x-body-file'}), 'TEST', 'request body - limit req - limited'); # request body delayed in limit_req - with an empty DATA frame # "zero size buf in output" alerts seen $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/proxy_limit_req/', body_more => 1 }); $s->h2_body(''); select undef, undef, undef, 1.1; $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is($frame->{headers}->{':status'}, 200, 'request body - limit req - empty'); # predict send windows $sid = $s->new_stream(); $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/proxy_limit_req/', body => 'TEST2' }); select undef, undef, undef, 1.1; $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is(read_body_file($frame->{headers}->{'x-body-file'}), 'TEST2', 'request body - limit req 2'); # partial request body data frame received (to be discarded) within request # delayed in limit_req, the rest of data frame is received after response $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/limit_req', body => 'TEST', split => [61], split_delay => 1.1 }); $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is($frame->{headers}->{':status'}, '200', 'discard body - limit req - limited'); $sid = $s->new_stream({ path => '/' }); $frames = $s->read(all => [{ sid => $sid, fin => 1 }]); ($frame) = grep { $_->{type} eq "HEADERS" } @$frames; is($frame->{headers}->{':status'}, '200', 'discard body - limit req - next'); # ditto, but instead of receiving the rest of data frame, connection is closed # 'http request already closed while closing request' alert can be produced $s = Test::Nginx::HTTP2->new(); $sid = $s->new_stream({ path => '/limit_req', body => 'TEST', split => [61], abort => 1 }); select undef, undef, undef, 1.1; close $s->{socket}; pass('discard body - limit req - eof'); ############################################################################### sub read_body_file { my ($path) = @_; return unless $path; open FILE, $path or return "$!"; local $/; my $content = <FILE>; close FILE; return $content; } ###############################################################################