Mercurial > hg > nginx-tests
view fastcgi_split.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 882267679006 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Test for fastcgi backend. # Incorrect split headers handling after switching to next server, # as reported by Lucas Molas. ############################################################################### use warnings; use strict; use Test::More; use Socket qw/ CR LF CRLF /; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; eval { require FCGI; }; plan(skip_all => 'FCGI not installed') if $@; plan(skip_all => 'win32') if $^O eq 'MSWin32'; my $t = Test::Nginx->new()->has(qw/http fastcgi/)->plan(1) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% upstream u { server 127.0.0.1:8081; server 127.0.0.1:8082; } server { listen 127.0.0.1:8080; server_name localhost; location / { fastcgi_pass u; fastcgi_param REQUEST_URI $request_uri; fastcgi_next_upstream invalid_header; } } } EOF $t->run_daemon(\&fastcgi_daemon, port(8081)); $t->run_daemon(\&fastcgi_daemon, port(8082)); $t->run(); $t->waitforsocket('127.0.0.1:' . port(8081)); $t->waitforsocket('127.0.0.1:' . port(8082)); ############################################################################### like(http_get('/'), qr/^Good: header/ms, 'fastcgi next upstream'); ############################################################################### sub fastcgi_daemon { my ($port) = @_; my $socket = FCGI::OpenSocket("127.0.0.1:$port", 5); my $request = FCGI::Request(\*STDIN, \*STDOUT, \*STDERR, \%ENV, $socket); my $count; while( $request->Accept() >= 0 ) { $count++; if ($port == port(8081)) { print 'BAD'; } if ($port == port(8082)) { print 'Good: header' . CRLF . CRLF; } } FCGI::CloseSocket($socket); } ###############################################################################