Mercurial > hg > nginx-tests
view http_variables.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 5ac6efbe5552 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # (C) Valentin Bartenev # Tests for http variables. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/http rewrite proxy/)->plan(7); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% log_format cc "$uri: $sent_http_cache_control"; server { listen 127.0.0.1:8080; server_name localhost; access_log %%TESTDIR%%/cc.log cc; location / { return 200 OK; } location /arg { return 200 $arg_l:$arg_; } location /set { add_header Cache-Control max-age=3600; add_header Cache-Control private; add_header Cache-Control must-revalidate; return 200 OK; } location /redefine { expires epoch; proxy_pass http://127.0.0.1:8080/set; } location /limit_rate { set $limit_rate $arg_l; add_header X-Rate $limit_rate; return 200 OK; } } } EOF $t->run(); ############################################################################### http_get('/'); http_get('/../bad_uri'); http_get('/redefine'); like(http_get('/arg?l=42'), qr/42:$/, 'arg'); # $limit_rate is a special variable that has its own set_handler / get_handler like(http_get('/limit_rate?l=40k'), qr/X-Rate: 40960/, 'limit_rate handlers'); like(http_get('/limit_rate'), qr/X-Rate: 0/, 'limit_rate invalid'); $t->stop(); my $log = $t->read_file('cc.log'); like($log, qr!^: -$!m, 'no uri'); like($log, qr!^/: -$!m, 'no header'); like($log, qr!^/set: max-age=3600, private, must-revalidate$!m, 'multi headers'); like($log, qr!^/redefine: no-cache$!m, 'ignoring headers with (hash == 0)'); ###############################################################################