Mercurial > hg > nginx-tests
view scgi_merge_params.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | 196d33c2bb45 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Maxim Dounin # Tests for scgi_param inheritance. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; eval { require SCGI; }; plan(skip_all => 'SCGI not installed') if $@; my $t = Test::Nginx->new()->has(qw/http scgi cache/)->plan(9) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } http { %%TEST_GLOBALS_HTTP%% scgi_cache_path %%TESTDIR%%/cache levels=1:2 keys_zone=NAME:1m; scgi_cache_key stub; scgi_param SCGI 1; scgi_param HTTP_X_BLAH "blah"; server { listen 127.0.0.1:8080; server_name localhost; scgi_cache NAME; location / { scgi_pass 127.0.0.1:8081; } location /no/ { scgi_pass 127.0.0.1:8081; scgi_cache off; } location /custom/ { scgi_pass 127.0.0.1:8081; scgi_param SCGI 1; scgi_param HTTP_X_BLAH "custom"; } } } EOF $t->run_daemon(\&scgi_daemon); $t->run()->waitforsocket('127.0.0.1:' . port(8081)); ############################################################################### like(http_get_ims('/'), qr/ims=;/, 'if-modified-since cleared with cache'); like(http_get_ims('/'), qr/iums=;/, 'if-unmodified-since cleared with cache'); like(http_get_ims('/'), qr/blah=blah;/, 'custom params with cache'); like(http_get_ims('/no/'), qr/ims=blah;/, 'if-modified-since preserved without cache'); like(http_get_ims('/no/'), qr/iums=blah;/, 'if-unmodified-since preserved without cache'); like(http_get_ims('/'), qr/blah=blah;/, 'custom params without cache'); like(http_get_ims('/custom/'), qr/ims=;/, 'if-modified-since cleared with cache custom'); like(http_get_ims('/custom/'), qr/iums=;/, 'if-unmodified-since cleared with cache custom'); like(http_get_ims('/custom/'), qr/blah=custom;/, 'custom params with cache custom'); ############################################################################### sub http_get_ims { my ($url) = @_; return http(<<EOF); GET $url HTTP/1.0 Host: localhost Connection: close If-Modified-Since: blah If-Unmodified-Since: blah EOF } ############################################################################### sub scgi_daemon { my $server = IO::Socket::INET->new( Proto => 'tcp', LocalHost => '127.0.0.1:' . port(8081), Listen => 5, Reuse => 1 ) or die "Can't create listening socket: $!\n"; my $scgi = SCGI->new($server, blocking => 1); while (my $request = $scgi->accept()) { eval { $request->read_env(); }; next if $@; my $ims = $request->env->{HTTP_IF_MODIFIED_SINCE} || ''; my $iums = $request->env->{HTTP_IF_UNMODIFIED_SINCE} || ''; my $blah = $request->env->{HTTP_X_BLAH} || ''; $request->connection()->print(<<EOF); Location: http://localhost/redirect Content-Type: text/html ims=$ims;iums=$iums;blah=$blah; EOF } } ###############################################################################