Mercurial > hg > nginx-tests
view stream_access_log_escape.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | f3ba4c74de31 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Sergey Kandaurov # (C) Nginx, Inc. # Stream tests for access_log with escape parameter. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; my $t = Test::Nginx->new()->has(qw/stream stream_map stream_return/) ->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } stream { %%TEST_GLOBALS_STREAM%% map $pid $a { default '" \ "'; } map $pid $b { default "foo"; } log_format json escape=json $a$b$upstream_addr; log_format default escape=default $a$b$upstream_addr; server { listen 127.0.0.1:8080; return ok; access_log %%TESTDIR%%/json.log json; access_log %%TESTDIR%%/test.log default; } } EOF $t->run()->plan(2); ############################################################################### http_get('/'); $t->stop(); is($t->read_file('json.log'), '\" \\\\ \"foo' . "\n", 'json'); is($t->read_file('test.log'), '\x22 \x5C \x22foo-' . "\n", 'default'); ###############################################################################