view stream_split_clients.t @ 1905:f35824e75b66

Tests: fixed reading QUIC streams on Perl < 5.24. The parse_stream() routine has had a missing explicit return if there were no streams received. In Perl < 5.24 this used to return no value, or an empty array in the list context. In modern Perl this returns an empty value, or an array of 1 element, which made the check for last index of the returned array work rather by accident. The fix is to return explicitly and to check the array size in callers instead.
author Sergey Kandaurov <pluknet@nginx.com>
date Tue, 06 Jun 2023 18:50:07 +0400
parents f3ba4c74de31
children
line wrap: on
line source

#!/usr/bin/perl

# (C) Sergey Kandaurov
# (C) Nginx, Inc.

# Tests for stream split_client module.

###############################################################################

use warnings;
use strict;

use Test::More;

BEGIN { use FindBin; chdir($FindBin::Bin); }

use lib 'lib';
use Test::Nginx;
use Test::Nginx::Stream qw/ stream /;

###############################################################################

select STDERR; $| = 1;
select STDOUT; $| = 1;

my $t = Test::Nginx->new()->has(qw/stream stream_split_clients stream_return/);

$t->write_file_expand('nginx.conf', <<'EOF');

%%TEST_GLOBALS%%

daemon off;

events {
}

stream {
    %%TEST_GLOBALS_STREAM%%

    split_clients $connection $variant {
        51.2%  "first";
        10%    "second";
        *      "third";
    }

    server {
        listen  127.0.0.1:8080;
        return  $variant;
    }
}

EOF

$t->run();
$t->plan(1);

###############################################################################

# NB: split_clients distribution is a subject to implementation details

like(many('/', 20), qr/first: 12, second: 2, third: 6/, 'split');

###############################################################################

sub many {
	my ($uri, $count) = @_;
	my %dist;

	for (1 .. $count) {
		if (my $data = stream('127.0.0.1:' . port(8080))->read()) {
			$dist{$data} = 0 unless defined $data;
			$dist{$data}++;
		}
	}

	return join ', ', map { $_ . ": " . $dist{$_} } sort keys %dist;
}

###############################################################################