Mercurial > hg > nginx-tests
view stream_unix.t @ 1905:f35824e75b66
Tests: fixed reading QUIC streams on Perl < 5.24.
The parse_stream() routine has had a missing explicit return if there were no
streams received. In Perl < 5.24 this used to return no value, or an empty
array in the list context. In modern Perl this returns an empty value, or an
array of 1 element, which made the check for last index of the returned array
work rather by accident.
The fix is to return explicitly and to check the array size in callers instead.
author | Sergey Kandaurov <pluknet@nginx.com> |
---|---|
date | Tue, 06 Jun 2023 18:50:07 +0400 |
parents | f3ba4c74de31 |
children |
line wrap: on
line source
#!/usr/bin/perl # (C) Andrey Zelenkov # (C) Nginx, Inc. # Simple tests for stream with unix socket. ############################################################################### use warnings; use strict; use Test::More; BEGIN { use FindBin; chdir($FindBin::Bin); } use lib 'lib'; use Test::Nginx; use Test::Nginx::Stream qw/ stream /; ############################################################################### select STDERR; $| = 1; select STDOUT; $| = 1; eval { require IO::Socket::UNIX; }; plan(skip_all => 'IO::Socket::UNIX not installed') if $@; my $t = Test::Nginx->new()->has(qw/stream unix/)->plan(2); $t->write_file_expand('nginx.conf', <<'EOF'); %%TEST_GLOBALS%% daemon off; events { } stream { %%TEST_GLOBALS_STREAM%% upstream u { server unix:%%TESTDIR%%/unix.sock; } server { listen 127.0.0.1:8080; proxy_pass unix:%%TESTDIR%%/unix.sock; } server { listen 127.0.0.1:8081; proxy_pass u; } } EOF my $path = $t->testdir() . '/unix.sock'; $t->run_daemon(\&stream_daemon, $path); $t->run(); # wait for unix socket to appear for (1 .. 50) { last if -S $path; select undef, undef, undef, 0.1; } ############################################################################### my $str = 'SEE-THIS'; is(stream('127.0.0.1:' . port(8080))->io($str), $str, 'proxy'); is(stream('127.0.0.1:' . port(8081))->io($str), $str, 'upstream'); ############################################################################### sub stream_daemon { my $server = IO::Socket::UNIX->new( Proto => 'tcp', Local => shift, Listen => 5, Reuse => 1 ) or die "Can't create listening socket: $!\n"; local $SIG{PIPE} = 'IGNORE'; while (my $client = $server->accept()) { $client->autoflush(1); log2c("(new connection $client)"); $client->sysread(my $buffer, 65536) or next; log2i("$client $buffer"); log2o("$client $buffer"); $client->syswrite($buffer); close $client; } } sub log2i { Test::Nginx::log_core('|| <<', @_); } sub log2o { Test::Nginx::log_core('|| >>', @_); } sub log2c { Test::Nginx::log_core('||', @_); } ###############################################################################